Skip to content

TINY-11907: Update the disabled option check #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiny-ben-tran merged 1 commit into from
Jun 3, 2025
Merged

TINY-11907: Update the disabled option check #419

tiny-ben-tran merged 1 commit into from
Jun 3, 2025

Conversation

@tiny-ben-tran
Copy link
Contributor

@tiny-ben-tran tiny-ben-tran commented Jun 2, 2025 •
edited
Loading

Ticket: TINY-11907

Description of changes:

  • Simplified the disabled option support check
  • Removed tests for TinyMCE v4

Note: CI will publish on merge

@tiny-ben-tran tiny-ben-tran requested review from a team, MitchC1999, jscasca, ltrouton and shanmen-tiny and removed request for a team June 2, 2025 05:41
@tiny-ben-tran tiny-ben-tran requested a review from a team as a code owner June 2, 2025 05:41
@tiny-ben-tran tiny-ben-tran requested review from TheSpyder and spocke and removed request for a team June 2, 2025 05:41
@tiny-ben-tran tiny-ben-tran changed the title TINY-11907: Simplify disabled option check TINY-11907: Update the disabled option check Jun 2, 2025
@tiny-ben-tran tiny-ben-tran merged commit 74c22a5 into main Jun 3, 2025
5 checks passed
@tiny-ben-tran tiny-ben-tran deleted the feature/TINY-11907_2 branch June 3, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimwoodfield kimwoodfield kimwoodfield approved these changes

@kemister85 kemister85 kemister85 approved these changes

@jscasca jscasca Awaiting requested review from jscasca jscasca was automatically assigned from tinymce/editor-platform-team

@ltrouton ltrouton Awaiting requested review from ltrouton ltrouton was automatically assigned from tinymce/editor-platform-team

@MitchC1999 MitchC1999 Awaiting requested review from MitchC1999 MitchC1999 was automatically assigned from tinymce/editor-platform-team

@shanmen-tiny shanmen-tiny Awaiting requested review from shanmen-tiny shanmen-tiny was automatically assigned from tinymce/editor-platform-team

@spocke spocke Awaiting requested review from spocke spocke is a code owner automatically assigned from tinymce/tinymce-reviewers

@TheSpyder TheSpyder Awaiting requested review from TheSpyder TheSpyder is a code owner automatically assigned from tinymce/tinymce-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiny-ben-tran @kimwoodfield @kemister85