Skip to content

Conversation

@threeal
Copy link
Owner

@threeal threeal commented Dec 3, 2022

modify how ok and error works by:

  • moving ok and error from res::internal to res namespace.
  • force to create a new res::Ok instance instead of using constant (for simplicity).
  • replace res::ErrMsgPtr that was using std::shared_ptr<std::string> to just using std::string (for simplicity).
  • create res::Err struct to wrap error data and force to create a new res::Err instance instead of just passing the error message.

@threeal threeal merged commit bda6848 into main Dec 3, 2022
@threeal threeal deleted the modify-ok-and-err branch December 3, 2022 14:15
@threeal threeal mentioned this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants