Skip to content

Rename res::ResultOr into res::ResultOf #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
threeal merged 1 commit into from
Dec 28, 2022
Merged

Rename res::ResultOr into res::ResultOf #16

threeal merged 1 commit into from
Dec 28, 2022

Conversation

@threeal
Copy link
Owner

@threeal threeal commented Dec 28, 2022

Simply rename res::ResultOr into res::ResultOf.

Reason: res::ResultOf is a container of T data so it's "result of T", instead of "result or T". Different from absl::StatusOr in which we could directly extract absl::Status from absl::StatusOr, hence it's "status or T".

@threeal threeal self-assigned this Dec 28, 2022
@threeal threeal added the feat label Dec 28, 2022
@threeal threeal marked this pull request as ready for review December 28, 2022 13:20
@threeal threeal merged commit c536229 into main Dec 28, 2022
@threeal threeal deleted the rename-result-or-to-result-of branch December 28, 2022 13:23
@threeal threeal mentioned this pull request Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@threeal threeal

Labels

feat

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@threeal