CI: Add manual trigger, bump action versions#113
Merged
Conversation
doi.org API changes have made our tests stale - this updates the outputs and adds a `Bibtex` class to facilitate comparisons.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 87.37% 87.41% +0.04%
==========================================
Files 6 6
Lines 301 302 +1
==========================================
+ Hits 263 264 +1
Misses 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
we could manually fix this in _to_bibtex by adding a .replace('
http://dx.doi.org/', 'https://doi.org/')
Yup, that's a great idea
…On Mon, Feb 26, 2024, 16:52 Mathias Goncalves ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In templateflow/tests/test_api.py
<#113 (comment)>
:
> @@ -14,30 +82,32 @@
mni2009_fbib = """\
@Article{Fonov_2011,
-\tdoi = {10.1016/j.neuroimage.2010.07.033},
-\turl = {https://doi.org/10.1016%2Fj.neuroimage.2010.07.033},
-\tyear = 2011,
-\tmonth = {jan},
-\tpublisher = {Elsevier {BV}},
-\tvolume = {54},
-\tnumber = {1},
-\tpages = {313--327},
-\tauthor = {Vladimir Fonov and Alan C. Evans and Kelly Botteron and C. Robert \
-Almli and Robert C. McKinstry and D. Louis Collins},
-\ttitle = {Unbiased average age-appropriate atlases for pediatric studies},
-\tjournal = {{NeuroImage}}
+DOI={10.1016/j.neuroimage.2010.07.033},
+url={http://dx.doi.org/10.1016/j.neuroimage.2010.07.033},
@oesteban <https://github.com/oesteban> yup, i'm not sure why crossref is
regressing (again)...
$ curl -LH "Accept: application/x-bibtex; charset=utf-8" https://doi.org/10.1016/j.neuroimage.2010.07.033
@Article{Fonov_2011, title={Unbiased average age-appropriate atlases for pediatric studies}, volume={54}, ISSN={1053-8119}, url={http://dx.doi.org/10.1016/j.neuroimage.2010.07.033}, DOI={10.1016/j.neuroimage.2010.07.033}, number={1}, journal={NeuroImage}, publisher={Elsevier BV}, author={Fonov, Vladimir and Evans, Alan C. and Botteron, Kelly and Almli, C. Robert and McKinstry, Robert C. and Collins, D. Louis}, year={2011}, month=jan, pages={313–327} }
we could manually fix this in _to_bibtex by adding a .replace('
http://dx.doi.org/', 'https://doi.org/')
—
Reply to this email directly, view it on GitHub
<#113 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAESDRW2L7A6VY5RKDDI4GDYVSVVNAVCNFSM6AAAAABDVTV3X6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMBRGI2TGNBTGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for a 24.0.0 release