-
Notifications
You must be signed in to change notification settings - Fork 37
Modernize #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Python 3.6 → 3.11 in runtime.txt - Create pyproject.toml with modern project metadata - Update all plotting libraries to latest versions: - plotly 4.10 → 5.24+ (no authentication needed) - plotnine → 0.13+ (better ggplot2 compatibility) - altair → 5.0+ (major version bump) - statsmodels 0.11 → 0.14+ (security fixes) - seaborn, pandas, matplotlib to latest - Remove deprecated packages: - altair-saver (use native rendering) - chart-studio (not needed with plotly v5) - duplicate selenium entry - Update rpy2 to 3.5+ for Python 3.11 compatibility 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Create setup_r.sh to install required R packages (ggplot2, mgcv) without requiring conda. Works with system R installations via Homebrew, apt, or CRAN. This allows using uv for Python dependencies while maintaining R integration through rpy2 with a separate R installation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Add 'setup' target to install dependencies with uv - Update 'dev_environment' to use new setup process - Remove 'plotly_auth' target (no longer needed with plotly v5) - Update .PHONY declarations - Add informative messages about conda → uv migration Core build targets (render, qrender, test) remain unchanged. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Add .github/workflows/deploy.yml with: - R 4.3 setup via r-lib/actions - Python 3.11 setup - uv for dependency installation - Firefox/geckodriver for selenium - xvfb for headless rendering - pytest test execution - Netlify deployment: - Production: master branch - Preview: other branches Required GitHub secrets: - NETLIFY_AUTH_TOKEN - NETLIFY_SITE_ID This modernizes CI from deprecated Travis CI to GitHub Actions with improved caching and faster builds. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Mark .travis/authenticate_plotly.py as deprecated with explanation. With plotly v5+, credentials are not required for local rendering. Plotly authentication is only needed for uploading to Chart Studio. This project renders plots locally to PNG using Kaleido, so no authentication is necessary. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
README.md: - Add modern development setup instructions with uv - Document system R installation requirements - Add build commands and CI/CD information - Clarify plotly no longer needs authentication CLAUDE.md: - Update all dependency versions and requirements - Document new uv-based setup process - Add comprehensive CI/CD section - Update technical constraints and configuration files - Add GitHub Actions workflow documentation Both files now reflect Python 3.11+, uv package manager, and GitHub Actions deployment to Netlify. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
MIGRATION_NOTES.md: - Comprehensive overview of all changes made - Detailed dependency update table - Next steps and setup instructions - Potential issues and rollback plan - Success criteria checklist TESTING_CHECKLIST.md: - Environment setup verification steps - Build testing procedures - Known migration issues to watch for - CI/CD testing guide - Performance check recommendations These documents provide guidance for the first build with modernized dependencies and help identify compatibility issues. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.