Repository navigation
Normative Conventions: pretend primitives aren't iterable - #152
Merged
Merged
Conversation
ljharb
approved these changes
Jun 19, 2024
bakkot
reviewed
Jun 19, 2024
bakkot
approved these changes
Jun 19, 2024
bakkot
left a comment
Member
There was a problem hiding this comment.
🎉
Gotta do that followup to add .codepoints() and/or similar methods for getting iterators though.
michaelficarra
force-pushed
the
michaelficarra-patch-1
branch
from
July 3, 2024 15:25
1627148 to
d428162
Compare
Member
Author
|
I think we could probably get away with also changing |
Member
|
|
2 of 5 tasks
Member
|
Possibly worth calling out that this applies to async-iterable-taking positions as well. |
michaelficarra
force-pushed
the
michaelficarra-patch-1
branch
from
July 23, 2024 17:58
311e718 to
a73fa06
Compare
Member
Author
|
@syg I've added the enumeration of all positions where primitives are currently iterated. Please review. |
bakkot
reviewed
Aug 2, 2024
Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
syg
reviewed
Aug 7, 2024
syg
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discussed this in the June plenary while considering iterator helper follow-on proposals. While we didn't call for consensus on it, there were many voices in support of this and none opposed. I will propose we officially adopt it at an upcoming plenary.