Skip to content

Conversation

@jacalata
Copy link
Contributor

@jacalata jacalata commented Nov 9, 2021

This is to create a temporary back compatible functionality for #617

@jorwoods
Copy link
Contributor

@jacalata Are all of the changes to other files due to black formatting? Do I need to run that on my other open PRs to reduce conflicts?

@jacalata jacalata force-pushed the jac/deprecated_hidden_views branch from 790da2b to e9ca881 Compare March 13, 2022 03:27
@bcantoni
Copy link
Contributor

@jacalata this looks pretty straightforward - will there be any doc changes we should make along with this?

@jacalata
Copy link
Contributor Author

@jacalata this looks pretty straightforward - will there be any doc changes we should make along with this?

Yea - not for this change, which is just making sure the old way of doing it keeps working, but I don't think we updated the docs for #617

@jacalata jacalata merged commit 7e5b513 into development Mar 17, 2022
@jacalata jacalata deleted the jac/deprecated_hidden_views branch March 17, 2022 00:15
jacalata added a commit that referenced this pull request Mar 30, 2022
* add back hidden_views to publish request as a deprecated option
jacalata added a commit that referenced this pull request Jun 1, 2022
* add back hidden_views to publish request as a deprecated option
jacalata added a commit that referenced this pull request Jun 6, 2022
* add back hidden_views to publish request as a deprecated option
jacalata added a commit that referenced this pull request Sep 20, 2022
* add back hidden_views to publish request as a deprecated option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants