Skip to content

Enable Black for CI and add as dependency #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jacalata merged 5 commits into from
Jan 28, 2022
Merged

Enable Black for CI and add as dependency #935

jacalata merged 5 commits into from
Jan 28, 2022

Conversation

@bcantoni
Copy link
Contributor

@bcantoni bcantoni commented Nov 1, 2021

First commit enabled Black for CI, so it should fail right away.

@bcantoni
Copy link
Contributor Author

bcantoni commented Nov 2, 2021

Okay, bulk reformat plus one manual fix for mypy type hint seem to make everything happy.

@jacalata
Copy link
Contributor

jacalata commented Jan 28, 2022

pretty sure I broke some of the new formatting in that merge :)

@jacalata jacalata merged commit b836f33 into development Jan 28, 2022
jorwoods added a commit to jorwoods/server-client-python that referenced this pull request Jan 28, 2022
@jorwoods
Squashed commit of the following:
83cfbe7 
commit b836f33
Author: Brian Cantoni <[email protected]>
Date:   Thu Jan 27 19:29:50 2022 -0800

    WIP: Enable Black for CI and add as dependency (tableau#935)

    * Enable Black for CI and add as dependency

    * Bulk reformat with Black, line length 120

    Co-authored-by: Jac Fitzgerald <[email protected]>
jorwoods added a commit to jorwoods/server-client-python that referenced this pull request Jan 28, 2022
@jorwoods
Squashed commit of the following:
25bf08b 
commit b836f33
Author: Brian Cantoni <[email protected]>
Date:   Thu Jan 27 19:29:50 2022 -0800

    WIP: Enable Black for CI and add as dependency (tableau#935)

    * Enable Black for CI and add as dependency

    * Bulk reformat with Black, line length 120

    Co-authored-by: Jac Fitzgerald <[email protected]>
jorwoods added a commit to jorwoods/server-client-python that referenced this pull request Jan 28, 2022
@jorwoods
Squashed commit of the following:
15a7211 
commit b836f33
Author: Brian Cantoni <[email protected]>
Date:   Thu Jan 27 19:29:50 2022 -0800

    WIP: Enable Black for CI and add as dependency (tableau#935)

    * Enable Black for CI and add as dependency

    * Bulk reformat with Black, line length 120

    Co-authored-by: Jac Fitzgerald <[email protected]>
jorwoods added a commit to jorwoods/server-client-python that referenced this pull request Jan 28, 2022
@jorwoods
Squashed commit of the following:
ed33744 
commit ed940a2
Author: Jac <[email protected]>
Date:   Thu Jan 27 20:16:31 2022 -0800

    make tests run even if code style fails (tableau#980)

commit fb49f31
Author: jorwoods <[email protected]>
Date:   Thu Jan 27 21:54:31 2022 -0600

    Jorwoods/type hint flows (tableau#937)

    * Type hint Flows

    * Type hint request_factory for flows

    * Add ConnectionItem type hints on to Flow publish request

    * Clean up flows publish signature

    * Fix flow update_permissions type hint

    * Fix update_permissions type hint

    * Add workbook.hidden_views type hint

    * Update permissions only accepts an iterable

    * Fix formatting

commit f40d4bc
Author: jorwoods <[email protected]>
Date:   Thu Jan 27 21:47:53 2022 -0600

    Jorwoods/type hint favorites (tableau#936)

    * Type hint Favorites

    * Type hint FavoriteRequest

commit 4d0142d
Author: jorwoods <[email protected]>
Date:   Thu Jan 27 21:45:14 2022 -0600

    Jorwoods/type hint data alert (tableau#934)

    * Type hint data alerts

    * Type hint DataAlertRequest

    * Remove type annotations from Frequency namespace

    * Update test_dataalert.py

commit b836f33
Author: Brian Cantoni <[email protected]>
Date:   Thu Jan 27 19:29:50 2022 -0800

    WIP: Enable Black for CI and add as dependency (tableau#935)

    * Enable Black for CI and add as dependency

    * Bulk reformat with Black, line length 120

    Co-authored-by: Jac Fitzgerald <[email protected]>
jorwoods added a commit to jorwoods/server-client-python that referenced this pull request Jan 28, 2022
@jorwoods
Squashed commit of the following:
f634580 
commit ed940a2
Author: Jac <[email protected]>
Date:   Thu Jan 27 20:16:31 2022 -0800

    make tests run even if code style fails (tableau#980)

commit fb49f31
Author: jorwoods <[email protected]>
Date:   Thu Jan 27 21:54:31 2022 -0600

    Jorwoods/type hint flows (tableau#937)

    * Type hint Flows

    * Type hint request_factory for flows

    * Add ConnectionItem type hints on to Flow publish request

    * Clean up flows publish signature

    * Fix flow update_permissions type hint

    * Fix update_permissions type hint

    * Add workbook.hidden_views type hint

    * Update permissions only accepts an iterable

    * Fix formatting

commit f40d4bc
Author: jorwoods <[email protected]>
Date:   Thu Jan 27 21:47:53 2022 -0600

    Jorwoods/type hint favorites (tableau#936)

    * Type hint Favorites

    * Type hint FavoriteRequest

commit 4d0142d
Author: jorwoods <[email protected]>
Date:   Thu Jan 27 21:45:14 2022 -0600

    Jorwoods/type hint data alert (tableau#934)

    * Type hint data alerts

    * Type hint DataAlertRequest

    * Remove type annotations from Frequency namespace

    * Update test_dataalert.py

commit b836f33
Author: Brian Cantoni <[email protected]>
Date:   Thu Jan 27 19:29:50 2022 -0800

    WIP: Enable Black for CI and add as dependency (tableau#935)

    * Enable Black for CI and add as dependency

    * Bulk reformat with Black, line length 120

    Co-authored-by: Jac Fitzgerald <[email protected]>

commit ad57851
Author: jorwoods <[email protected]>
Date:   Thu Nov 11 15:55:01 2021 -0600

    Jorwoods/type hint revisions (tableau#956)

    Add type hints and tests for workbook and data source revisions

commit bb0feb8
Author: elsherif <[email protected]>
Date:   Wed Nov 10 01:21:16 2021 +0100

    Add support to datasource and workbook revisions (tableau#931)

    * add support to datasource and workbook revisions (get all item revisions / downlad item by revision number)

    * add type hints

    * remove wrong type hints

commit 31d420f
Author: Stephen Mitchell <[email protected]>
Date:   Tue Nov 9 01:02:14 2021 -0500

    Clean up hidden_views by making it an attribute of WorkbookItem (tableau#617)

    * Clean up hidden views and make it an attribute of workbookitem

    * Pycodestyle error fix for one letter variable

    Co-authored-by: Jac <[email protected]>
    Co-authored by: Stephen Mitchell https://github.com/scuml

commit 7443f68
Author: jorwoods <[email protected]>
Date:   Sun Nov 7 05:57:42 2021 -0600

    Add type hints to `Job` (tableau#939)

commit c8170ae
Author: Tyler Doyle <[email protected]>
Date:   Mon Nov 1 20:36:17 2021 -0400

    Fix slack once and for all (tableau#946)

    The red X keeps coming back so I'd like to mark this as allowably fail-able -- that way the innards of Slack/OAuth/Tableau credentials don't keep polluting test run reports :)

commit 946469c
Author: jorwoods <[email protected]>
Date:   Mon Nov 1 14:33:22 2021 -0500

    Type hinting on Datasources and Workbooks (tableau#804)

    Adds types to function signatures for Workbook and Data Source endpoints.
    Co-authored-by: Jordan Woods <[email protected]>

commit feed39c
Author: Brian Cantoni <[email protected]>
Date:   Tue Oct 26 08:04:10 2021 -0700

    Switch to release Python 3.10 release for CI (tableau#927)

    * Switch to release Python 3.10 release for CI

commit 4007d3d
Author: Jac <[email protected]>
Date:   Fri Oct 22 19:06:20 2021 -0700

    Jac/publish samples (tableau#918)

    * add publish-samples option to create/update project

commit a899a95
Author: mmuttreja-tableau <[email protected]>
Date:   Thu Oct 21 12:10:37 2021 -0400

    Adjusting changelog to include  missing updates for release 0.17 (tableau#922)

commit f81039a
Merge: fefd6f1 46bbe2e
Author: mmuttreja-tableau <[email protected]>
Date:   Wed Oct 20 17:43:50 2021 -0400

    Merge pull request tableau#921 from tableau/development

    Merging Development to Main branch for releasing v 0.17

commit 46bbe2e
Author: mmuttreja-tableau <[email protected]>
Date:   Wed Oct 20 17:26:45 2021 -0400

    Update contributors and Changelog for Release 0.17 (tableau#920)

    * Update CONTRIBUTORS.md & changelog for v 0.17

    Update contributors & changelog for v 0.17

commit 428eb55
Author: jorwoods <[email protected]>
Date:   Tue Oct 19 12:32:51 2021 -0500

    Add FlowRun Item and Endpoints. (tableau#884)

    * Add tests for fetching flow runs

    * Implement basics of FlowRuns

    * Add tests for cancel flow run

    * Make FlowRuns a Queryset endpoint for easier filtering

    * Add test for flow refresh endpoint

    * Align to naming conventions

    * Apply name change consistently

    * Change flowrun_id into flow_run_id

    * Add wait_for_job to FlowRun

    * Tag wait_for_job with version number

    * Rewrite flow_run to use ExponentialBackoffTimer

    * Test flow run wait with backoff

    * Remove 3.5 from test matrix

    * Standardize spelling of cancelled

    Co-authored-by: Jordan Woods <[email protected]>

commit fefd6f1
Merge: 1d8a9be 0845b7b
Author: Jac <[email protected]>
Date:   Thu Sep 2 17:49:07 2021 -0700

    Merge pull request tableau#880 from tableau/upgrade-slack-action

    Upgrade to newer Slack action provider

commit 0845b7b
Author: Brian Cantoni <[email protected]>
Date:   Wed Sep 1 14:22:53 2021 -0700

    Upgrade to newer Slack action provider

commit 1d8a9be
Merge: 5cbfc34 770d48a
Author: Ovini Nanayakkara <[email protected]>
Date:   Fri Jul 16 12:42:30 2021 -0400

    Merge pull request tableau#864 from tableau/development

    Merging Development to Main branch

commit 5cbfc34
Merge: ec3cc50 ffefd80
Author: Jac <[email protected]>
Date:   Wed Jun 23 23:33:47 2021 -0700

    Merge pull request tableau#851 from tableau/jacalata-patch-1

    Create slack.yml action

commit ffefd80
Author: Jac <[email protected]>
Date:   Mon May 24 13:34:07 2021 -0700

    whitespace change to re-try PR

commit 0c4fd4a
Author: Jac <[email protected]>
Date:   Mon May 24 13:15:49 2021 -0700

    Create slack.yml

    Created a new action from https://github.com/marketplace/actions/send-message-to-slack
jacalata pushed a commit that referenced this pull request Jan 28, 2022
@jorwoods
Add type hints for schedules (#969)
bb70890 
* Add type hints for schedules

* Squashed commit of the following:

commit b836f33
Author: Brian Cantoni <[email protected]>
Date:   Thu Jan 27 19:29:50 2022 -0800

    WIP: Enable Black for CI and add as dependency (#935)

    * Enable Black for CI and add as dependency

    * Bulk reformat with Black, line length 120

* Update interval_item.py

fixing DailyInterval has no attribute 'interval'
jorwoods pushed a commit to jorwoods/server-client-python that referenced this pull request Jan 28, 2022
@bcantoni @jacalata
WIP: Enable Black for CI and add as dependency (tableau#935)
d9c0df4 
* Enable Black for CI and add as dependency

* Bulk reformat with Black, line length 120

Co-authored-by: Jac Fitzgerald <[email protected]>
jorwoods pushed a commit to jorwoods/server-client-python that referenced this pull request Jan 28, 2022
@bcantoni @jacalata
WIP: Enable Black for CI and add as dependency (tableau#935)
8ae79be 
* Enable Black for CI and add as dependency

* Bulk reformat with Black, line length 120

Co-authored-by: Jac Fitzgerald <[email protected]>
jorwoods added a commit to jorwoods/server-client-python that referenced this pull request Jan 28, 2022
@jorwoods
Squashed commit of the following:
4aad0fd 
commit b836f33
Author: Brian Cantoni <[email protected]>
Date:   Thu Jan 27 19:29:50 2022 -0800

    WIP: Enable Black for CI and add as dependency (tableau#935)

    * Enable Black for CI and add as dependency

    * Bulk reformat with Black, line length 120

    Co-authored-by: Jac Fitzgerald <[email protected]>
jorwoods added a commit to jorwoods/server-client-python that referenced this pull request Jan 28, 2022
@jorwoods
Squashed commit of the following:
bc8b043 
commit b836f33
Author: Brian Cantoni <[email protected]>
Date:   Thu Jan 27 19:29:50 2022 -0800

    WIP: Enable Black for CI and add as dependency (tableau#935)

    * Enable Black for CI and add as dependency

    * Bulk reformat with Black, line length 120

    Co-authored-by: Jac Fitzgerald <[email protected]>
@bcantoni bcantoni changed the title WIP: Enable Black for CI and add as dependency Enable Black for CI and add as dependency Jan 31, 2022
@bcantoni bcantoni mentioned this pull request Jan 31, 2022
Closed
bcantoni added a commit that referenced this pull request Jan 31, 2022
@bcantoni
Update dev guide to reflect switch from pycodestyle to black
7c6bfc9 
Follow-on to code and CI pipeline changes in #935

Fixes #933
@bcantoni bcantoni mentioned this pull request Jan 31, 2022
Merged
bcantoni added a commit that referenced this pull request Feb 1, 2022
@bcantoni
Update dev guide to reflect switch from pycodestyle to black (#983)
5e6edaf 
Follow-on to code and CI pipeline changes in #935

Fixes #933
jorwoods added a commit to jorwoods/server-client-python that referenced this pull request Feb 18, 2022
@jorwoods
Squashed commit of the following:
faceac9 
commit b836f33
Author: Brian Cantoni <[email protected]>
Date:   Thu Jan 27 19:29:50 2022 -0800

    WIP: Enable Black for CI and add as dependency (tableau#935)

    * Enable Black for CI and add as dependency

    * Bulk reformat with Black, line length 120

    Co-authored-by: Jac Fitzgerald <[email protected]>
jorwoods added a commit to jorwoods/server-client-python that referenced this pull request Feb 18, 2022
@jorwoods
Squashed commit of the following:
a432b94 
commit b836f33
Author: Brian Cantoni <[email protected]>
Date:   Thu Jan 27 19:29:50 2022 -0800

    WIP: Enable Black for CI and add as dependency (tableau#935)

    * Enable Black for CI and add as dependency

    * Bulk reformat with Black, line length 120

    Co-authored-by: Jac Fitzgerald <[email protected]>
jacalata added a commit that referenced this pull request Mar 30, 2022
@bcantoni @jacalata
WIP: Enable Black for CI and add as dependency (#935)
c8c23f1 
* Enable Black for CI and add as dependency

* Bulk reformat with Black, line length 120

Co-authored-by: Jac Fitzgerald <[email protected]>
jacalata pushed a commit that referenced this pull request Mar 30, 2022
@jorwoods @jacalata
Add type hints for schedules (#969)
2373133 
* Add type hints for schedules

* Squashed commit of the following:

commit b836f33
Author: Brian Cantoni <[email protected]>
Date:   Thu Jan 27 19:29:50 2022 -0800

    WIP: Enable Black for CI and add as dependency (#935)

    * Enable Black for CI and add as dependency

    * Bulk reformat with Black, line length 120

* Update interval_item.py

fixing DailyInterval has no attribute 'interval'
@jacalata jacalata deleted the finish-black-formatter branch March 30, 2022 04:56
jacalata added a commit that referenced this pull request Jun 1, 2022
@bcantoni @jacalata
WIP: Enable Black for CI and add as dependency (#935)
5c5b311 
* Enable Black for CI and add as dependency

* Bulk reformat with Black, line length 120

Co-authored-by: Jac Fitzgerald <[email protected]>
jacalata added a commit that referenced this pull request Jun 6, 2022
@bcantoni @jacalata
WIP: Enable Black for CI and add as dependency (#935)
cdc4928 
* Enable Black for CI and add as dependency

* Bulk reformat with Black, line length 120

Co-authored-by: Jac Fitzgerald <[email protected]>
jacalata added a commit that referenced this pull request Sep 20, 2022
@bcantoni @jacalata
WIP: Enable Black for CI and add as dependency (#935)
06348fa 
* Enable Black for CI and add as dependency

* Bulk reformat with Black, line length 120

Co-authored-by: Jac Fitzgerald <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@t8y8 t8y8 t8y8 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bcantoni @jacalata @t8y8