Add example for querying metadata API #895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t8y8
suggested changes
Sep 20, 2021
Collaborator
t8y8
left a comment
There was a problem hiding this comment.
Minor request and then looks good.
b9f29f2 to
23f0303
Compare
Collaborator
Author
|
@t8y8 I changed the sample so it is also possible to query all data sources and rebased the PR on the |
t8y8
approved these changes
Sep 23, 2021
Collaborator
t8y8
left a comment
There was a problem hiding this comment.
🚀
I think the sample looks good -- we still need to fix the pipeline though. Let me see if I can do that from the outside world
Collaborator
|
I can't see why the python tests don't run -- they worked when @bcantoni added python 3.10 and haven't since, but I remember seeing them run on that PR itself (across linux, mac, and windows no less). I will file an issue, this is blocking a ton of open PRs (maybe just revert the slack action?) |
Contributor
|
@vogelsgesang this looks ready for merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.