Cleanup duplications #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 28, 2016 13:18
t8y8
approved these changes
Oct 28, 2016
Collaborator
t8y8
left a comment
There was a problem hiding this comment.
🚀
Minor requests, I trust a ship it after they're addressed
|
|
||
| class Auth(Endpoint): | ||
| def __init__(self): | ||
| super(Auth, self).__init__(None) |
Collaborator
There was a problem hiding this comment.
Keyword argument? I don't know what None means it kinda makes me think it's passing some fake value
| def _check_status(server_response): | ||
| if server_response.status_code not in Success_codes: | ||
| raise ServerResponseError.from_response(server_response.content) | ||
| def _make_headers(token, content_type): |
Collaborator
There was a problem hiding this comment.
_make_tableau_headers or _make_server_headers or something to indicate it's not a totally general purpose function, it really is Tableau REST API specific headers
| self._check_status(server_response) | ||
|
|
||
| # This check is to determine if the response is a text response (xml or otherwise) | ||
| # so that we do not attempt to log bytes and other binary data. |
LGraber
reviewed
Oct 28, 2016
| retval['content-type'] = content_type | ||
|
|
||
| def get_unauthenticated_request(self, url, request_object=None): | ||
| def _make_request(self, method, url, content=None, request_object=None, token=None, content_type=None): |
bryceglarsen
pushed a commit
to bryceglarsen/server-client-python
that referenced
this pull request
Dec 28, 2023
…ableau#89) When Cross Database Joins were introduced in 10 all connections became "federated" by default, even if they weren't actually joined to anything else. In the file format that means they get represented as named-connection/connection elements. Expressed under one top-level connection element with a class of 'federated'. Except for 'sqlproxy' connections (Published Data Sources) -- they stay in the old connection style as a top level connection element. We need to, when in a 10.0 or greater workbook, get all federated connections (named-connection) plus go back and find any sqlproxy connections as well.
bryceglarsen
pushed a commit
to bryceglarsen/server-client-python
that referenced
this pull request
Dec 28, 2023
…ableau#89) When Cross Database Joins were introduced in 10 all connections became "federated" by default, even if they weren't actually joined to anything else. In the file format that means they get represented as named-connection/connection elements. Expressed under one top-level connection element with a class of 'federated'. Except for 'sqlproxy' connections (Published Data Sources) -- they stay in the old connection style as a top level connection element. We need to, when in a 10.0 or greater workbook, get all federated connections (named-connection) plus go back and find any sqlproxy connections as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up the Endpoint base object and removing the duplicate ctors across all endpoints.