Skip to content

Conversation

@annematronic
Copy link
Contributor

Changes include:

  • Update request factory to add name attribute when present.
  • Update Datasource tests to assert name (and some other properties that were not already asserted)
  • Updated other Datasource tests which were passing 'project_id' and 'name' in the incorrect order to the DatasourceItem constructor

Copy link
Contributor

@shinchris shinchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment in test, but otherwise looks good!

@shinchris shinchris merged commit 5d333f5 into tableau:development May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants