Skip to content

Conversation

@opus-42
Copy link
Contributor

@opus-42 opus-42 commented Aug 25, 2018

Hello,

I noticed that some property fields which are available in the rest API for View Items where not implemented. Here is an implementation for the following fields as describe in the XML schema (https://onlinehelp.tableau.com/samples/en-us/rest_api/ts-api_3_0.xsd) : created_at, updated_at, sheet_type.

The following modification have been applied :

  • Add field property and parsing to ViewItem class
  • Add fields to test assets
  • Add relevant test
  • Update documentation.

I noticed that while describe in the API doc, the sheet_type does not appear in the response on API version 3.0 (tested on Tableau Online).

@t8y8
Copy link
Collaborator

t8y8 commented Sep 10, 2018

Hello!

Thank you for your contribution!

The code looks good but I have a few asks of you:

@opus-42 opus-42 changed the base branch from master to development September 23, 2018 15:39
@opus-42
Copy link
Contributor Author

opus-42 commented Sep 23, 2018

Hello @t8y8,

To answer your questions :

  • Yes I did sign the CLA.
  • I've just changed the base branch of this PR to the develpment branch.

Copy link
Collaborator

@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we can confirm the receipt of the CLA, this looks good to me!

(I believe @RussTheAerialist and @benlower have access to check)

@opus-42
Copy link
Contributor Author

opus-42 commented Apr 15, 2019

Hello, any update on this Pull Request ?

Thanks

@jacalata jacalata merged commit 4a279ad into tableau:development Jul 25, 2019
@shinchris shinchris mentioned this pull request Oct 4, 2019
shinchris pushed a commit that referenced this pull request Oct 4, 2019
Release v0.9
## 0.9 (4 Oct 2019)

* Added Metadata API endpoints (#431)
* Added site settings for Data Catalog and Prep Conductor (#434)
* Added new fields to ViewItem (#331)
* Added support and samples for Tableau Server Personal Access Tokens (#465)
* Added Permissions endpoints (#429)
* Added tags to ViewItem (#470)
* Added Databases and Tables endpoints (#445)
* Added Flow endpoints (#494)
* Added ability to filter projects by topLevelProject attribute (#497)
* Improved server_info endpoint error handling (#439)
* Improved Pager to take in keyword arguments (#451)
* Fixed UUID serialization error while publishing workbook (#449)
* Fixed materalized views in request body for update_workbook (#461)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants