Repository navigation
Conversation
CLI benchmark: no changes foundCommit
API calls: unchanged for all 7 commands. Binary size: 134.0 MB, unchanged. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
There was a problem hiding this comment.
Superseded by a newer AI review
🤖 AI Review
Both independent reviews completed and reported no findings. Code inspection of the Docker API gating, health-start flags, and Kong readiness changes found no additional actionable issues.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
avallete
left a comment
There was a problem hiding this comment.
Dogfooded locally on Docker (API 1.56) against develop: start with the issue's excludes, full stack restart, db start, db reset, status and stop all pass and are noticeably faster. The db container gets the 1s start interval and 10s start period, and kong answers /rest/v1/ with 200 when start returns.
Non-blocking notes:
- With
[api.tls] enabled, the kongstartingprobe goes tohttps://on the local port. If the HTTP client doesn't trust the local cert, it fails quietly and falls back to the 10s wait (no breakage, just no speedup). - On a non-loopback services host (remote Docker or
SUPABASE_SERVICES_HOSTNAME) with a proxy that doesn't exclude it, a proxy response could count as kong ready. Loopback already bypasses proxies and the existinggateway-reachablefallback has the same exposure, so not introduced here. - A few new comments use
/* */instead of/** *////, and theHEALTH_START_PERIOD_SECONDSandlocalApiUrlones could be clearer.
Not covered: Docker API < 1.44 and Podman.
|
/ai-review |
There was a problem hiding this comment.
🤖 AI Review
Verified both reported findings against the checked-out code. Confirmed one JSDoc nit; the claimed Docker documentation inaccuracy remains uncertain. Codex reported no findings. No runtime defects were verified.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | apps/cli/src/command-internal/db-bootstrap/docker-create-args.ts:26 |
documentation |
claude | The startIntervalSeconds field uses a plain block comment containing a JSDoc link, so TypeScript editors will not expose that documentation or resolve its link on hover. |
| ⚪ NIT | apps/cli/src/commands/stop/SIDE_EFFECTS.md:166 |
documentation |
claude | The documentation attributes the three-version minimum to Docker, although the reviewer claims checking DefaultAPIVersion is an additional conservative CLI restriction. |
Stats
Claude findings: 2 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 1
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: manual · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
TL;DR
fixes
supabase startsitting about 10s on docker's first health check when the services are already up.whats improved/fixed?
docker runs a container's first health check one full interval after it starts, and our interval is 10s.
so
supabase startkept waiting on that check even when everything was ready sooner.a restart with the issue's excludes went from about 12.8s to 5.2s.
a full stack restart went from about 14s to 8s
db startanddb resetget the same.how?
containers with a docker healthcheck now get
--health-start-interval 1sand a 10s start period whendocker versionshows API 1.44 or newer for the client binary, the client in use, and the daemon, so the first check runs about 1s in and the interval stays 10s after.kong's check lived only in its image, so its spec now sets the same
kong healthcheck and gets those flags too.Note
on engines without the flag (docker below API 1.44, podman) containers keep the 10s first check.
ref:
supabase startwaits about 10 seconds for Docker's first health check after services are ready #7427