Repository navigation
Fix #649: a panel dropped on the dock lights up where it goes - #652
Merged
Merged
Conversation
Panels other than Properties, Layers and Libraries live in the dock's icon column, not as tabs. Dragging one onto the dock lit up the whole dock, tabs included, and the drop put it back as an icon, so it seemed to vanish. The drop zone now lights up the icon column for such panels (the whole dock still for the tabbed ones), and the dropped panel pops out of its icon. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #649.
What and why
Only Properties, Layers and Libraries are tabs in the dock. Every other panel (Color, Swatches, Stroke…) lives in the icon column and opens as a flyout. Dragging a floating Color panel over the dock lit up the whole dock, tabs included, which suggests it would join the tabs. The drop then put it back as an icon in the column, so it seemed to vanish.
Closing a floating group with its × and Window › Dock Panel behave as before.
How it was tested
a_panel_dropped_on_the_dock_lights_up_and_pops_out_of_its_icon: Color, held over the Layers tab, lights up the icon column (narrower than the dock); released, it's back in the column and open as a flyout. The existing Layers test now also asserts that the whole dock lights up for a tab.cargo xtask cipasses.Limit
Docking any panel as a new tab beside Properties/Layers/Libraries isn't supported yet, since the tabbed group has a fixed set of tabs. This change makes the feedback match what happens.
🤖 Generated with Claude Code