Repository navigation
Land #631 (ICF character alignment) and #632 (French interface) - #635
Merged
Merged
Conversation
…acter face) Character panel menu › Character Alignment gains ICF Top/Right and ICF Bottom/Left, and `charAlign` takes `icfTop` / `icfBottom`: a character smaller than the largest on its line lines up its ideographic character face's top (right, vertical) or bottom (left) with the big one's. `FontFace::icf_margins` places the ICF inside the em box as the OpenType baseline tags define it (https://learn.microsoft.com/en-us/typography/opentype/spec/baselinetags): `icfb` / `icft` of the BASE table's horizontal and vertical axes against `ideo` / `idtp` (else the OS/2 typographic descender and one em), for Han ideographs (else kana, else the first script). Without them, as that page allows, the average ink box of some ideographs and kana; a face without ideographs uses its em box. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add fr.tsv with the full interface coverage: every menu string, every tl! literal, the plurals and the status/error messages (@msg). Registered as complete_menus with the French plural rule (0 and 1 are singular); every fr-* locale (fr-FR, fr-BE, fr-CA, fr-CH …) resolves to it. Keeps the product, workspace and perspective preset names in English like the other complete catalogs. Tests: french_reads_as_french; fr added to KEEPS_MENU_NAMES and COMPLETE_MESSAGES; the Latin-script glyph test covers French letters and the no-break space; locale tests use de-DE as the unsupported case. Clean-room: written from the meaning of the English labels in the vocabulary French-speaking users of vector illustration software know (Plan de travail, Nuancier, Contour, Fond, Tracé, Calque). No other application's localisation was copied. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
French now sits between Spanish and Italian (es, fr, it, ru): the plural rule, the LANGUAGES registry entry (so the Language menu lists Français before Italiano), the locale tests, the fr() helper and french_reads_as_french. README, ROADMAP and docs/development.md list the languages in the same order. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
These labels reach the screen through helpers that translate their argument (dim_label, dropdown, tl!(CONST)), so the tl! literal scan doesn't see them: the Libraries panel's empty state, Recolor Artwork's 1/2/3 Color Job presets, Spot Colors' CMYK Equivalents, the Eyedropper's 3 x 3 / 5 x 5 Average, Print's PDF File destination and Save PDF's CMYK profile in effect output intent. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Free Transform's widget (Free Transform, Perspective Distort, Constrain), the Properties panel's artboard editing (Artboard, Exit) and Type › Insert Inline Symbol, found by the catalog completeness tests after the rebase. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…graphic character face) # Conflicts: # ROADMAP.md # crates/text/src/layout.rs
# Conflicts: # ROADMAP.md
…alog) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands two community PRs, keeping their original commits, plus two fixes of ours:
charAlign: icfTop | icfBottom). The ICF comes from the BASE table or OS/2 per the OpenType baseline-tags spec.tl!literals, plurals,@msgmessages), with everyfr-*locale resolving to it.TextRuns with M7: inline symbols in text #627'sinlinefield, added while Type: Character Alignment on the ICF top and bottom (ideographic character face) #631 was open.align_shiftdoc comment conflict (Type: Character Alignment on the ICF top and bottom (ideographic character face) #631's ICF text plus M7: inline symbols in text #627's inline-graphic note) and the ROADMAP conflicts are resolved in the merges.Checks
origin/maina29563f.cargo xtask cion this exact tree: all 7 steps passed.app.language fr): the menu bar, Properties panel, task bar, tool groups and status bar render and fit with the bundled fonts.🤖 Generated with Claude Code