Repository navigation
Tests: the eyedropper image-sampling test no longer flakes (colour settings changed by parallel tests) - #61
Merged
Merged
Conversation
The engine unit tests share one process, and two colour-management tests switched the process-wide Color Settings (the working RGB space to the wide gamut profile, Black Point Compensation off) for a moment. Any test that showed or rendered a colour at that moment saw it through the wrong profile: clicking_an_image_samples_its_pixel read #008181 instead of #008080. - Move the two tests that change the Color Settings to their own test binary (crates/engine/tests/color_settings.rs), so no unit test can see non-default settings. - The image-sampling test compares the stored colour, not its display hex. - every_command_survives_empty_params toggles the process-wide proof view (Proof Colors, Overprint Preview, Separations), so it now takes the colour-management test lock like the tests that read that view. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests_eyedropper::clicking_an_image_samples_its_pixelfailed at random in parallel CI runs (#008181instead of#008080). This finds the cause and removes it.tests_colormgmt::GLOBAL, but every test that shows or renders a colour reads those settings without the lock, so for that moment colours went through the wrong profile.crates/engine/tests/color_settings.rs), so they run in a separate process. A lock couldn't fix this, because every colour reader would need it. No engine unit test now leaves the Color Settings off their defaults.every_command_survives_empty_paramstoggles the process-wide proof view (view.proofColors,view.overprintPreview,view.separationsPreview), which other locked tests assert on, so it now takes the existingGLOBALlock.Checks
Rebased onto
0038e00.cargo xtask cipasses all 7 steps (fmt, clippy, test, assets, brands, layers, wasm): 1,886 tests, 0 failed.Stress runs, with 0 failures in each:
🤖 Generated with Claude Code