Repository navigation
Fix #555: the font menu scrolls only its list - #562
Merged
Merged
Conversation
egui's combo box puts its own scroll area around a combo's list, so the font menu, which scrolls its families itself, had two scrollbars: once the families reached their end the wheel scrolled the outer one, taking the search field and the filters out of view. The font menu (widgets::combo with searchable) now opens its list in a popup of its own, drawn like the combo box, without that outer scroll area: below the button, or above it when there is more room there. The families list fills the popup's room under the search field and filters, which stay at the top while the list scrolls. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bflatastic
added a commit
that referenced
this pull request
Oct 8, 2026
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The font menu had two scrollbars and could scroll its search field out of view; now only the families list scrolls.
widgets::combowithsearchable(only the font menu uses it) opens a popup of its own instead ofegui::ComboBox's, whose list is always wrapped in a ScrollArea. The button is drawn as the combo box draws it. The popup opens below the button, or above when there is more room there, and its height is capped at that room.font_menu: the families list fills the popup's room under the search field and filters, instead of measuring to the window's bottom (which overflowed into the outer scroll area).Tried in the desktop app: the Properties panel's font menu opens below its button and the Character flyout's opens under its own. Each has one scrollbar, and scrolling to Yu Gothic UI keeps the search field and filters in view.
Checks
cargo test -p vectorcraft-ui-egui(756 passed),cargo clippy -p vectorcraft-ui-egui --all-targets -- -D warnings,cargo fmt --all,cargo xtask wasm.🤖 Generated with Claude Code