Repository navigation
Fix #550: an SVG of chosen artboards holds only their art - #558
Merged
Merged
Conversation
Exporting one artboard of many to SVG wrote the whole document's art into that artboard's file, the other artboards' art outside its viewBox: an editor opening it showed every artboard's art. A file for an artboard named in the export (Use Artboards with a range or All, Export for Screens) now holds the objects over that artboard only, at any depth of layers, as DXF's crop leaves them; objects reaching into it stay whole and a clipping layer keeps all of its objects. An SVG with no artboard named (Save As) still holds the whole document. Part of #546: Export As with a range writes the chosen artboard alone in SVG, DXF, PDF and PNG, each file with that artboard's art (tested from the dialogs). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An SVG exported for one artboard of many now holds that artboard's art, not the whole document's.
Fixes #550
Part of #546
fileio::export::art_over: the document with only the objects whose visual bounds reach an artboard, at any depth of layers and sublayers (objects reaching in stay whole; a clipping layer keeps all its objects). The SVG encoder uses it for each artboard the export names (Use Artboards with a range or All, Export for Screens). With no artboard named (Save As SVG) the whole document is written, as before.artboardeach hold only their artboard's shapes, an un-named export holds both; UI — Export As with Use Artboards and Range 1 / 3 writes exactly one file in SVG, DXF, PDF and PNG, and the SVG and DXF hold the art only when it is on that artboard. An SVG Options test that exported an empty artboard now picks artboard 1.useArtboardsoption text and docs/mcp.md; ROADMAP Last updated.#546 (DXF) is not fixed here: I couldn't reproduce lost art. In an 80-artboard document, Export As → DXF with Use Artboards and Range 80 (and the same through
document.export, including an Image Trace object on artboard 80) writes one drawing with that artboard's fills as solid HATCHes, origin at its corner, extents right. Ways the reporter could see "only the outline":The reporter's file, or the DXF version they picked, would settle it.
Checks
cargo test -p vectorcraft-engine -p vectorcraft-ui-egui,cargo clippy -p vectorcraft-engine -p vectorcraft-ui-egui --all-targets -- -D warnings,cargo fmt --all,cargo xtask wasm.🤖 Generated with Claude Code