Repository navigation
Part of #394: Auto-Collapse Iconic Panels - #488
Merged
Merged
Conversation
Preferences › User Interface › Auto-Collapse Iconic Panels was stored and never read: a panel popped out of the icon column stayed until its » or its icon. On, a press away from the flyout now puts it away. A press on the icon column is left to the icons (they swap or close the flyout on release, so acting on the press would reopen the one being closed), and a press in a popup the flyout opened (a panel menu, a dropdown) keeps it. Off by default, as in Illustrator. Developed with AI assistance (Claude Code); reviewed and tested locally. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… (review of storytold#488) - A press inside a dialog the popped-out panel opened (Swatch Options from its menu, say), or on a modal dialog's backdrop, put the panel away under the dialog. The press now counts as away only when it lands on no foreground layer (the flyout itself, dialogs, palettes) and not on the modal backdrop (`dialogs::modal::backdrop`), as the popovers decide a click elsewhere. - A press in the expanded dock's panel group left the flyout open: only the icon column is spared now (its icons swap or close the flyout themselves), so a click in another docked panel puts it away, as a click anywhere else in the workspace does in the reference app. - The test covers a click in a dialog, on its backdrop and in the docked group. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bflatastic
force-pushed
the
feat/issue-394-auto-collapse
branch
from
October 8, 2026 13:34
6390658 to
d728c47
Compare
Member
|
Thanks @wstock, sparing the icon column and the panel's own popups was well thought through. We added one commit:
Full |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #394. Preferences › User Interface › Auto-Collapse Iconic Panels (
autoCollapseIconPanels) was stored and never read: a panel popped out of the icon column stayed open until its » or its icon.Now
egui::Popup::is_any_open).Tests
dock::tests::auto_collapse_puts_a_flyout_away_on_a_click_elsewhere(the dock harness, headless egui frames on a 1600 × 1000 window): off, a click elsewhere leaves the Layers flyout;prefs.set autoCollapseIconPanels=true→ a click elsewhere puts it away; its icon still pops it out; a click inside keeps it; another icon swaps it; the same icon puts it away.cargo test -p vectorcraft-ui-egui dock::tests6/6;cargo clippy -p vectorcraft-ui-egui --all-targets -- -D warningsclean for the changed files (the only errors onmainare the pre-existingchunks_exactones inui-egui/src/cursors.rs, allowed for the run).cargo fmtapplied.Docs
docs/mcp.md:autoCollapseIconPanelsadded to the view preferences paragraph.No new
tl!literals (no catalog changes). Note: #484 and #486 (also #394, from me) each also take the ROADMAP count 38 → 37 on the same lines, so whichever lands last will need a one-word rebase.Developed with AI assistance (Claude Code); reviewed and tested locally.