Repository navigation
Artboards panel: clicking an artboard makes it the active one - #351
Merged
bflatastic merged 2 commits intoOct 7, 2026
Merged
Conversation
…it active The panel kept its own selection (a pstate nothing else read), so a click only highlighted the row: the status bar navigator, Fit Artboard in Window and Actual Size stayed on the previous artboard. The panel's selection is now the view's active artboard (View::artboard): a click, Move Up/Down and New Artboard set it, and the highlight follows the navigator, per document, as in the reference app. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rtboard tool (review of storytold#351) As in Illustrator, double-clicking an artboard's number goes to it (fits it in the window) and double-clicking the name renames it. A row's Options button chooses the Artboard tool on that row's artboard, clicking a row moves the Artboard tool to it while it is chosen, and an artboard clicked with the Artboard tool becomes the active one the panel highlights. Note it in the ROADMAP. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bflatastic
force-pushed
the
fix/artboards-panel-activates
branch
from
October 7, 2026 20:52
16c035a to
3b2376a
Compare
Member
|
Thanks @theironchef, merged! A row click now makes that artboard the active one for the navigator and the Fit/Actual Size commands. I rebased it on main and added one commit on top:
Live check: clicking Artboard 2 made it active with the view unchanged, double-clicking its number fitted it (navigator showed 2), and clicks with the tool on the canvas moved the panel's highlight. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #349.
Problem: the Artboards panel kept its own selection (
pstate "ab-sel") that nothing outside the panel read. A click on a row highlighted it but didn't make that artboard active, so the status bar navigator, View › Fit Artboard in Window and Actual Size stayed on the previous artboard. The selection was also shared by every open document. In Illustrator, selecting an artboard's name in the panel makes it the active artboard (Select artboards).Change (
crates/ui-egui/src/panels/artboards.rs)View::artboard, which the navigator and the Fit/Actual Size commands already use.ab-selstate is gone.Tests
panels::artboards::tests::clicking_a_row_makes_its_artboard_active, with two artboards and headless frames with pointer events:cargo test -p vectorcraft-ui-egui: 570 passed.cargo clippy -p vectorcraft-ui-egui --all-targets -- -D warnings(Rust 1.99): clean.cargo fmt --all -- --check: clean.I didn't run the full
cargo xtask ci(wasm step) here. The Artboard tool still keeps its own active artboard: making it follow the panel would be a separate change.🤖 Generated with Claude Code