Repository navigation
EPS import: EPS files from the reference app open as vectors - #331
Merged
h-a-n-a-s-h-i merged 1 commit intoOct 7, 2026
Merged
Conversation
storytold#249 made the reduced repros of storytold#234 open, but a real file saved by the reference app (version 30) still fell back to its screen-resolution preview with "typecheck in `a dictionary`". Running its prolog to the end needed: - The standard dictionaries (systemdict, userdict, globaldict, statusdict, errordict, $error) as values in systemdict, so `/globaldict where { /globaldict get begin } if` gets a dictionary, not an operator. SharedFontDirectory names the font directory too. errordict has a handleerror for prologs that wrap it. - `dictstack`, `internaldict`, `currentsystemparams` and `currentuserparams` (with the cache sizes programs `get`), and `cshow`. - Executable files: `cvx` and `cvlit` set a file's attribute, `xcheck` reads it, and executing one runs its data as a program, as the prolog does with `(...) 0 () /SubFileDecode filter cvx exec`. - SubFileDecode with a count of 0 and an empty end string passes its whole source through instead of nothing. - `flushfile` on a filter over the program's data skips that data (the file's XMP packet). A filter chained from a pending one leaves it nothing to skip, so the writer's own `VCsrc flushfile` is unchanged. The interpreter empties its standard dictionaries when it finishes, since systemdict now holds itself. Both real files tested now import as 15 vector paths in CMYK with no warnings, and round-trip through SVG and PDF pixel for pixel. The EPS fuzzer exercises the new operators. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bflatastic
added a commit
that referenced
this pull request
Oct 7, 2026
…ble-file tests (review of #331) Laying out type (show, stringwidth, cshow) costs about 300 operations plus 64 a character, measured, and now counts that much against MAX_OPS: a 300-byte file running cshow over a 4 MB string took 60 s, and { (a) stringwidth pop pop } loop ran for over 5 minutes (already the case on main); both now stop with "the program runs too long" within seconds. Tests: executable filters run inside themselves stop at the nesting limit (directly, mutually and under stopped), currentfile cvx exec runs nothing twice, cshow over a long string is refused; the hostile PostScript fuzz tokens gain self-recursive filter execution, currentfile filters, cvlit and cshow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bflatastic
added a commit
that referenced
this pull request
Oct 7, 2026
Member
|
Thanks @EthanSuquet! This is merged. The standard dictionaries as values, Since the interpreter runs untrusted files, I threw hostile PostScript at it while reviewing. Self, mutual and
|
This was referenced Oct 7, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #234 / #249. Real EPS files saved by the reference app (v30) still fell back to their preview, failing with
typecheck in \a dictionary``. Working through the real prolog turned up these gaps:globaldict,userdictand the other standard dictionaries were operators, not values stored in systemdict, so/globaldict get beginfailed (crates/eps/src/import/interp.rs).dictstack,internaldict,currentsystemparams/currentuserparams,cshow,SharedFontDirectoryand errordicthandleerrorwere missing.cvx execon a file didn't run its data.0 ()didn't pass data through.flushfiledidn't skip a filter's data (the embedded XMP).Fix: all of the above. The dictionaries are emptied when the interpreter finishes, since systemdict now contains itself and would otherwise leak. The EPS fuzzer gets the new tokens, and
docs/mcp.mdand the ROADMAP are updated.Tests:
cargo fmt --checkandcargo clippy -D warningsare clean. Not run locally: the fullcargo xtask ci(wasm, layers).Refs #234
🤖 Generated with Claude Code