Repository navigation
Pen: holding Space while dragging out a point moves it - #315
Merged
bflatastic merged 2 commits intoOct 7, 2026
Merged
Conversation
…s it The Pen ignored Space during a drag, so the anchor being placed stayed where the button went down and its handles swung round it. Space held now moves the anchor, handles and all, as far as the pointer moves (the handle Alt kept moves along too); releasing Space goes back to shaping the handles round the new place, as in the reference app. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…storytold#315) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bflatastic
force-pushed
the
fix/pen-space-moves-anchor
branch
from
October 7, 2026 20:48
7fbd477 to
c322f24
Compare
Member
|
Thanks @theironchef, merged! Holding Space while dragging out a point now moves it, handles and all. I rebased it on main and added the ROADMAP entry in a commit on top. Live check: Space held mid-drag moved the anchor to (300,60) with its handles at (240,60) / (360,60), and releasing Space went back to shaping the handles. Also checked over MCP. One follow-up you might like: Illustrator also lets Space reposition the closing anchor while closing a path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #313. Stacked on #310: the first commit here is #310's. Once that one merges, this PR shows only its own commit.
Problem: the Pen never read Space during a drag. Holding it while dragging out a point left the anchor where the button went down, and its handles swung round it. In Illustrator, holding the spacebar while the button is still down moves the anchor being placed, with its handles. That's the Pen's counterpart of #302 / #304 for the shape tools.
Change (
crates/tools/src/pen.rs)PenToolremembers the pointer at the last button-down or drag (last).path.create) and an anchor added to a path (path.appendAnchor).canvas::mods(m, space)), so nothing else changes.Tests
pen::tests::space_moves_the_anchor_being_placed:cargo test -p vectorcraft-tools: 190 passed.cargo test -p vectorcraft-engine --lib pen: 59 passed.cargo clippy -p vectorcraft-tools --all-targets -- -D warnings(Rust 1.99): clean.cargo fmt --all -- --check: clean.M0.5 50.576 C0.5 50.576 20.53 20.303 100.652 0.5: the anchor at about (150, 100) instead of (150, 150), with its incoming handle mirroring the final outgoing one.I didn't run the full
cargo xtask ci(wasm step) here.🤖 Generated with Claude Code