Skip to content

PDF/.ai import: art of a neighbouring artboard stays on its own page - #286

Merged
bflatastic merged 4 commits into
storytold:mainfrom
p0lyg0n:fix/ai-neighbouring-artboards
Oct 7, 2026
Merged

bflatastic merged 4 commits into
storytold:mainfrom
p0lyg0n:fix/ai-neighbouring-artboards

Conversation

@p0lyg0n

@p0lyg0n p0lyg0n commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

A PDF-compatible file with several artboards writes, on each page, the art of its neighbours that reaches into the page's box, shifted by its own artboard spacing. The importer kept those copies, so art from one artboard came back a second time on the next page, offset by a few points, and drew over that page's own art (in the file I hit, a hologram image covered a card's stripes and title).

With several pages, art lying wholly outside a page's box now stays with the page it belongs to. A single page keeps its art off the page (the pasteboard) as before.

Test (tests_import_options.rs): page 2 also draws page 1's square outside its box. Page 1 keeps it and page 2 doesn't, and a single page still keeps it.

cargo xtask ci passes.

🤖 Generated with Claude Code

theironchef and others added 4 commits October 7, 2026 13:19
… typed

egui reports the character a key types, so Cmd+Shift+[ arrives as
Cmd+Shift+{ (], / likewise as }, ?) and Shift+` as the text ~, and these
default shortcuts never matched: Bring to Front, Send to Back, Search
Commands and the Curvature tool. Command chords now also take the
shifted character, single-key tool and command shortcuts also look up
Shift+<typed text>, and the Keyboard Shortcuts editor records such a
chord as its key (Cmd+Shift+], not Cmd+Shift+}), so conflicts show.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e caret there

The Selection tool's double-click on text only switched to the Type
tool, which then had nothing being edited, so typing went to the tool
shortcuts (X swapped the text's fill and stroke). After such a switch
the canvas passes the double-click on to the Type tool as a click, which
starts editing the type with the caret where it was clicked.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Art dragged off the canvas and released over the Symbols panel's list
becomes a new symbol (symbol.new with the dragged ids), and a symbol
dragged out of the panel (PanelDrag::Symbol) is placed on the canvas
centred where it is dropped (symbol.place), showing its thumbnail at
the pointer on the way.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A file with several artboards writes, on each page, the art of its
neighbours that reaches the page's box, shifted by its own artboard
spacing. Kept, those copies drew over the art of the page they came from
(a hologram over its card's stripes and title). With several pages, art
wholly outside a page's box now stays with the page it belongs to.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bflatastic
bflatastic force-pushed the fix/ai-neighbouring-artboards branch from 6983453 to d5e21cc Compare October 7, 2026 06:30
@bflatastic
bflatastic merged commit 89ff09e into storytold:main Oct 7, 2026
@bflatastic

Copy link
Copy Markdown
Member

Thank you @p0lyg0n, merged! I rebased it on main and added a ROADMAP note under PDF/.ai import. I also checked it with the CLI on a generated two-page PDF whose second page repeats the first page's square off to its left: objects per page went from [2, 1] to [1, 1], and a single page still keeps its off-page art.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants