Skip to content

Fix #221: Effect > Pathfinder works on several selected objects - #227

Merged
bflatastic merged 1 commit into
mainfrom
fix/issue-221
Oct 6, 2026
Merged

bflatastic merged 1 commit into
mainfrom
fix/issue-221

Conversation

@bflatastic

@bflatastic bflatastic commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Fixes #221: Effect ▸ Pathfinder (Add, Intersect, Exclude, Subtract…) now works when several loose objects are selected.

  • Grouping: a Pathfinder effect combines the contents of a group or layer. Applied to several selected objects, none of them a group, it now groups them first and applies the live effect to the group, in the same undo step. The result shows right away and stays editable in the Appearance panel.
  • Unchanged cases: a selection that already holds a group, a single object, or an explicit ids, item or target applies as before.
  • Agents: effect.apply returns grouped: true when it grouped. The params doc and docs/mcp.md say so.
  • Refactor: the Group command's body is now object::group_nodes, shared by both.

Checks

  • Rebased on main at 2ba0e1f (Fix #177: DXF Fit and Aligned text span their two points #226).
  • cargo xtask ci passes all 7 steps (fmt, clippy, test, assets, brands, layers, wasm) with 3,308 tests.
  • New test pathfinder_effect_on_loose_objects_groups_them_first:
    • The objects are grouped in their stacking order, and the group carries the live effect and is selected.
    • Expanding leaves one united path.
    • One undo restores the loose objects with no effect.
    • A single object gets the effect as before.

🤖 Generated with Claude Code

Choosing an Effect > Pathfinder item (Add, Intersect, Exclude, Subtract...)
with several loose objects selected now groups them and applies the live
effect to the group, in one undo step, so the result shows at once and stays
editable. A selection that already holds a group, or a single object, works
as before, and agents get `grouped: true` back when it happens.

Root cause: Pathfinder effects combine the contents of a group or layer.
Applied to loose objects, each one got an effect with nothing to combine, so
nothing visibly changed, while the Pathfinder panel's commands (found by the
command search) act on the selection directly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bflatastic
bflatastic merged commit 2f743f1 into main Oct 6, 2026
p0lyg0n pushed a commit to p0lyg0n/vectorcraft that referenced this pull request Oct 7, 2026
…n fixes

storytold#226, storytold#227 and storytold#243 landed without their ROADMAP lines: Shipped so far now
says DXF Fit and Aligned text span their two points, Effect > Pathfinder
groups several loose objects first, and names are never translated; the
Last updated line counts the 2026-10-07 issue fixes. Scores unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pathfinder in navbar effect doesn't work

1 participant