Repository navigation
Fix #80: the hint bar names keys as the menus do (Alt and Ctrl off macOS) - #150
Merged
Merged
Conversation
…cOS)
The hint bar's segments were hard-coded strings with macOS names (Option,
Cmd) next to one Alt. The hints now write keys as shortcut strings
("Alt+Click") and show them through the menus' pretty_shortcut, and the
fallback hint shows the effective Search Commands shortcut (or the menu
item when it has none).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80: the hint bar names keys the way the menus do: Alt and Ctrl on Windows and Linux, ⌥ and ⌘ on macOS.
hint_forhad the key names hard-coded. Hints now write keys as shortcut strings ("Alt+Click") and display them throughmenus::pretty_shortcut, so every hint agrees with the menus, the Eyedropper's included.hints_name_keys_as_the_menus_do. Screenshots on Windows show "Alt+Click" and "Ctrl+Shift+/".Checks
mainate94dfed(Fix #136: SVG export and CSS write each style's numeric font-weight #148). All five branches rebased without conflicts.cargo xtask cipasses all 7 steps (fmt, clippy, tests, assets, brands, layers, wasm) at the top of the stack: 2,958 tests.main, the stack keeps every test, engine command, UI command, menu entry and MCP tool, and no existing test changed. The only removed default shortcut is Edit Contents' Cmd+Shift+V (see Bug: Ctrl+Shift+V behaves identically to Ctrl+V instead of Performing "Paste in Place" #34).🤖 Generated with Claude Code