Repository navigation
Fix #83: Ctrl and + zooms in however + is typed (numpad, Shift+=, a + key) - #149
Merged
Merged
Conversation
… key) The shortcut parser mapped "=" to Key::Equals and the matcher only took that exact key, while egui reports the numpad plus, and + on layouts that give it its own key (and often Shift+=), as Key::Plus. "+" and "=" now parse to one chord key, a recorded + is stored as =, and the matcher lets a = chord take Key::Plus too (also next to the native macOS menu, which handles only the chord as written). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83: Ctrl and + zooms in however + is typed: numpad +, Shift+=, or a layout with its own + key.
=intoKey::Equals, but egui reports the numpad + and a dedicated + key asKey::Plus.+and=now parse to the same chord key, and a recorded+is stored as=. The newshortcuts::consumelets an=chord also takeKey::Plus.plus_typed_any_way_zooms_in. Also checked in the running app: Ctrl+Plus zooms from 164% to 200%.Checks
mainate94dfed(Fix #136: SVG export and CSS write each style's numeric font-weight #148). All five branches rebased without conflicts.cargo xtask cipasses all 7 steps (fmt, clippy, tests, assets, brands, layers, wasm) at the top of the stack: 2,958 tests.main, the stack keeps every test, engine command, UI command, menu entry and MCP tool, and no existing test changed. The only removed default shortcut is Edit Contents' Cmd+Shift+V (see Bug: Ctrl+Shift+V behaves identically to Ctrl+V instead of Performing "Paste in Place" #34).🤖 Generated with Claude Code