Repository navigation
Fix #139: SVG import paints paint-order="stroke" text strokes under the letters - #147
Merged
Merged
Conversation
…he letters The text import reads <text> from the XML and never looked at paint-order, so character strokes always painted over the fill. A text whose characters all share one stroke painted first now gets that stroke as the object's own stroke below the Characters row (as the canvas, SVG and PDF export already draw it), with its gradient or pattern resolved in the document; characters with differing strokes keep them and the import warns. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #139: text with
paint-order="stroke"imports with its stroke under the letters.paint-order. When every character shares one stroke that paints before the fill, that stroke now becomes the text object's own stroke, placed below the Characters row, and the characters' own strokes are cleared. The canvas, SVG export and PDF export already draw this correctly.crates/svg/tests/text_paint_order.rs, including a pixel probe that finds 411 yellow letter pixels with the fix and 0 without it.Checks
mainat088ffc8(Fix #87: rust-version 1.95 and clippy 1.95 #144).cargo xtask cipasses all 7 steps (fmt, clippy, tests, assets, brands, layers, wasm) at the top of the stack, with 2,935 tests.🤖 Generated with Claude Code