New versioning and fix for License #619
Conversation
c543f61 to
029af19
Compare
| on: | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
@1nv0k32 isn't this inverted? The release-dev.yml us the tag branches and the release.yml uses branch main?
There was a problem hiding this comment.
It's the same behaviour as it was before. When you merge something into main, if there was no tag, you were considering it as a dev release, and if you were tagging main, you were considering it as a release. I've done the same, but in two separate files.
|
|
||
| [build-system] | ||
| requires = ["hatchling"] | ||
| requires = ["hatchling", "hatch-vcs"] |
There was a problem hiding this comment.
Why do we need hatch-vcs? Can't we just continue having the version on pyproject.toml and avoid an extra dependency?
It is also possible to have dynamic version like this with hatch alone.
There was a problem hiding this comment.
I thought it's cooler and easier to maintain.
But if you prefer the regex method, I can change it back.
ACTIVATE TAG PROTECTION FOR ALL TAGS
With this PR, we are creating:
vN.N.Nformat. -> version format:1.3.31.3.4.dev3+gc543f61Licensing issue is fixed.
Closes #618