[5.x] Ensure updated_at and updated_by is not null in TracksLastModified #13099
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of our customer projects that we finally were allowed to update to v5 we encountered an error when saving certain entries:
On closer inspection it turned out that the affected entries have
updated_at: nullin their data. I currently can't quite figure out why that is the case, but this causes a problem inTracksLastModified::lastModified():The entry has
updated_at, but it isnull, causing the Carbon error.This PR simply changes the
lastModified()function (andlastModifiedBy()too, for good measure) to not just check if the key is there, but also if its truthy.