Print unequal sample sizes in loo_compare#307
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #307 +/- ##
==========================================
+ Coverage 92.76% 92.78% +0.01%
==========================================
Files 31 31
Lines 2986 2992 +6
==========================================
+ Hits 2770 2776 +6
Misses 216 216 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jgabry
reviewed
Oct 20, 2025
Member
jgabry
left a comment
There was a problem hiding this comment.
Thanks! This looks good at first glance but I haven't had a chance to try it out yet. Busy day for me today but will try it out as soon as I can.
Member
|
I just added one more test to also include the scenario where the user supplies custom model names (by providing the models as a named list). |
jgabry
approved these changes
Oct 21, 2025
Member
jgabry
left a comment
There was a problem hiding this comment.
I think this is ready to merge once the checks pass (I just pushed one commit so rerunning them)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #296.