Skip to content

Fixed NAs in psis_r_eff #301

Merged
jgabry merged 5 commits intomasterfrom
fix-na-psisreff
Oct 7, 2025
Merged

Fixed NAs in psis_r_eff #301
jgabry merged 5 commits intomasterfrom
fix-na-psisreff

Conversation

@VisruthSK
Copy link
Member

Fixed NA issues in psis_r_eff by replacing NA values with 1s.

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 84.90566% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.76%. Comparing base (119be4a) to head (bf7aec8).

Files with missing lines Patch % Lines
R/psis.R 84.90% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
- Coverage   92.78%   92.76%   -0.02%     
==========================================
  Files          31       31              
  Lines        2964     2986      +22     
==========================================
+ Hits         2750     2770      +20     
- Misses        214      216       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I just made one comment about the message.

@n-kall
Copy link
Contributor

n-kall commented Oct 7, 2025

I think the comment above the function can be updated to add this case

@jgabry
Copy link
Member

jgabry commented Oct 7, 2025

This looks good. Will go ahead and merge. Thanks @VisruthSK.

@jgabry jgabry merged commit cd6715d into master Oct 7, 2025
6 checks passed
@jgabry jgabry deleted the fix-na-psisreff branch October 7, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants