Fix E_loo_khat error when posterior::pareto_khat returns NA#264
Merged
Fix E_loo_khat error when posterior::pareto_khat returns NA#264
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #264 +/- ##
==========================================
+ Coverage 92.68% 92.69% +0.01%
==========================================
Files 31 31
Lines 2842 2846 +4
==========================================
+ Hits 2634 2638 +4
Misses 208 208 ☔ View full report in Codecov by Sentry. |
Member
|
Doesn't look nice, but I don't see how else to do it |
avehtari
approved these changes
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #263
This avoids the error mentioned by @bgoodri in #263 by first checking if
posterior::pareto_khatreturns a list or NA.