fix loo_model_weights naming for list of loo objects#217
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
==========================================
+ Coverage 93.05% 93.09% +0.04%
==========================================
Files 30 30
Lines 2766 2768 +2
==========================================
+ Hits 2574 2577 +3
+ Misses 192 191 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
avehtari
approved these changes
Mar 26, 2023
Member
avehtari
left a comment
There was a problem hiding this comment.
Tested. Works now as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #165 by getting model names for
loo_model_weightseven if list of loo objects is only partially named@avehtari Does this behave as expected now?