Conversation
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 94.15% 95.29% +1.13%
==========================================
Files 27 27
Lines 2633 2633
==========================================
+ Hits 2479 2509 +30
+ Misses 154 124 -30
Continue to review full report at Codecov.
|
topipa
approved these changes
Jul 8, 2020
Collaborator
topipa
left a comment
There was a problem hiding this comment.
Thanks for spotting and fixing this mistake! Should have been more thorough with the tests to catch this...
jgabry
approved these changes
Jul 9, 2020
Member
|
Thanks for fixing. I'll have time to do another CRAN submission Thursday night or Friday. @topipa if you have time before then can you add a test for this on the |
Collaborator
|
Test added. Thanks for the quick response on this! |
Member
|
Sorry for the delay on this. Resubmitting today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a typo in
loo_moment_matchthat prevented...to be passed to theloo_moment_match_splitmethod. This causes trouble as soon as any additional argument is passed to the helper functions of moment matching. I should have seen this earlier (before the loo release) but unfortunately I didn't.@jgabry we should make another small CRAN update as soon as possible to make moment matching generally usable with additional arguments.