Fix aliases usage on bblfsh client impl. #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Jun 19, 2019
session.go
Outdated
| } | ||
|
|
||
| for _, dm := range driverManifests { | ||
| for _, a := range dm.Aliases { |
There was a problem hiding this comment.
S1011: should replace loop with c.supportedLanguages = append(c.supportedLanguages, dm.Aliases...) (from gosimple)
kuba--
approved these changes
Jun 19, 2019
erizocosmico
approved these changes
Jun 19, 2019
ab8ebc5 to
f481e74
Compare
Contributor
|
CI is failing |
a981170 to
912b4e9
Compare
- Add aliases to supportedLanguages slice to check also alias names. - Make IsSupported to check lang names in lower case. - Update go-mysql-server to fix some nil handling errors. - Fix regression query that was using DISTINCT on aggregations giving wrong results. - Update minimal supported bblfsh version on documentation. Signed-off-by: Antonio Navarro Perez <[email protected]>
912b4e9 to
f3cf734
Compare
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
kuba--
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrong results.
Signed-off-by: Antonio Navarro Perez [email protected]
make upgradecommand if applicable.