Upgrade mysql + integrate with auth interface. #610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erizocosmico
approved these changes
Nov 7, 2018
jfontan
reviewed
Nov 7, 2018
Contributor
jfontan
left a comment
There was a problem hiding this comment.
Changes look good but it would be nice to enable audit by default in the logs. In server.go just before calling buildDatabase you can wrap the auth with Audit with these lines:
audit := auth.NewAuditLog(logrus.New())
c.userAuth = auth.NewAudit(c.userAuth, audit)
After that there should be audit trail logs.
Contributor
|
@kuba-- could you have a look at Javi's comment? After that LGTM. |
Contributor
Author
|
@jfontan - now we have nice/colourful audit logs in gitbase ;) |
jfontan
approved these changes
Nov 7, 2018
mcarmonaa
approved these changes
Nov 8, 2018
Contributor
|
@kuba-- I don't know what is happening with Travis, it is not triggered. Can you rebase please? |
Signed-off-by: kuba-- <[email protected]>
Contributor
Author
|
@ajnavarro - done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuba-- [email protected]
Closes src-d/go-mysql-server#468