Implement indexes #310
Merged
Implement indexes #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Appears that is out of date with master, can you rebase it? |
Signed-off-by: Manuel Carmona <manu.carmona90@gmail.com>
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
This PR adds support for unpacked objects, which made the index contain different objects and not match the result of the query without indexes. A bunch of integration tests for indexes of all tables testing they output the exact same thing as the same query without indexes have been added as well. Because it's super important to ensure the index is closed so it can be released, each index iterator has now a call to `closeIndexOnError`, which closes the index if there is an error or EOF in an iterator, ensure it's *always* closed. Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
6246981 to
1df4314
Compare
Contributor
Author
|
Done |
ajnavarro
approved these changes
Jun 14, 2018
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Contributor
|
@erizocosmico LGTM |
ajnavarro
suggested changes
Jun 14, 2018
Contributor
Author
|
That's weird, let me investigate |
Contributor
Author
|
Upgraded go-mysql-server with the fixes for the issues you mentioned |
5876521 to
f1e1c35
Compare
Contributor
Author
|
Updated go-mysql-server with |
Contributor
|
@erizocosmico there is something missing from go-mysql-server or can we upload it to latest master version? |
Contributor
|
I think this is missed: src-d/go-mysql-server#223 |
Contributor
Author
|
Yes, that was missing, I'll update that |
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
f1e1c35 to
fca56c6
Compare
ajnavarro
approved these changes
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #253
We should be able to release a version with indexes after this.