Skip to content

ProtoReader RECURSION_LIMIT is not configurable and is not following protobuf default  #3085

Description

@jianchaoxudd

Hi team,

The RECURSION_LIMIT=65 in ProtoReader is not configurable where grpc allows configurable limit and it is not following protobuf default(100)

Activity

  1. oldergod commented on Sep 4, 2024

    @oldergod
    Member

    Have you needed more than 65?

  2. jianchaoxudd commented on Sep 4, 2024

    @jianchaoxudd
    Author

    hey @oldergod ,

    Yes, our service has more than 65 depth, but not more than 100(protobuf default) yet.

  3. oldergod commented on Sep 5, 2024

    @oldergod
    Member

    I think we'll change our value to 100 for now. We can offer an option to configure it in the future.

  4. jianchaoxudd commented on Sep 5, 2024

    @jianchaoxudd
    Author

    Sounds good. Changing to 100 is good enough for now.

  5. jianchaoxudd commented on Sep 6, 2024

    @jianchaoxudd
    Author

    Thanks for the quick fix! @oldergod , how long it takes to release the fix?

  6. oldergod commented on Sep 10, 2024

    @oldergod
    Member

    This week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions