Skip to content

Evaluator refactor #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ldecheverz-split merged 74 commits into from
Mar 9, 2021
Merged

Evaluator refactor #190

ldecheverz-split merged 74 commits into from
Mar 9, 2021

Conversation

@ldecheverz-split
Copy link
Contributor

@ldecheverz-split ldecheverz-split commented Mar 5, 2021

Merging Evaluator-refactor to development

sanzmauro and others added 30 commits December 7, 2020 13:03
@sanzmauro
added EvaluatorImp and cleanup code from splitclientImp
2b4f178
@sanzmauro
added UT
61ee728
@sanzmauro
Merge pull request #172 from splitio/evaluator-polishing-ut
71b3fe5 
Evaluator implementation - UT
@sanzmauro
cleaning sonarqube warnings
495332f
@sanzmauro
cleaning code
895dca1
@sanzmauro
wip
e10331c
@sanzmauro
pr feedback
166146b
@sanzmauro
Merge pull request #173 from splitio/add-evaluator-implementation
9130bb7 
Created EvaluatorImp and decouple code from SplitClientImp
@sanzmauro
Matchers refactor
9cabb70
@sanzmauro
Merge pull request #174 from splitio/dependecy-matcher-refactor
4f104b9 
Update Dependency matcher to receive evaluator as param
@sanzmauro
added splitCache and splitFetcher refactor
af68d6a
@sanzmauro
traffic type exists refactor
0bc7d56
@sanzmauro
pr feedback
1c45e77
@sanzmauro
Merge pull request #175 from splitio/split-fetcher-refactor-storage
f3d0ddb 
Splits fetcher: Decouple storage
@sanzmauro
renamed provider to task and refactor
f78a355
@sanzmauro
wip
9aded16
@sanzmauro
wip
9eb18e5
@sanzmauro
pr feedback
f0d0bc6
@sanzmauro
rename and refactor
b698c90
@sanzmauro
pr feedback
e30b7b0
@sanzmauro
Merge pull request #177 from splitio/cache-move-package-and-rename
d3f672d 
moved package and rename split fetcher
@sanzmauro
Merge pull request #176 from splitio/split-fetcher-refactor-task
76669cd 
Splits fetcher: Decouple periodic task
@sanzmauro
input validation refactor
7367ceb
@sanzmauro
add uts
ba6f604
@sanzmauro
fixed build
d3f9360
@sanzmauro
feedback
5e1e63c
@sanzmauro
renamed metric label
ddff5f3
@sanzmauro
pr feedback
5ff4607
@ldecheverz-split
Decouple of segment storage. Segment Cache implementation.
cc25ae0
@ldecheverz-split
Merge branch 'evaluator-refactor' of https://github.com/splitio/java-…
646cfd3 
…client into decouple-segment-storage
ldecheverz-split and others added 24 commits January 13, 2021 11:55
@ldecheverz-split
Deleting 'volatile'
97e604f
@ldecheverz-split
Changing the way the getInstance is synchronized
86c473e
@ldecheverz-split
Changing the sinchronization. Last time
e97c7cc
@ldecheverz-split
Fix white space
30d1a4c
@sanzmauro
Merge pull request #184 from splitio/factory-instantiation-service
7b0a410 
[Lucas] Factory instantiation service
@sanzmauro
cleanup
d8adbf5
@sanzmauro
Factory code cleanup
041d12b
@sanzmauro
Revert "Factory code cleanup"
4bee2e3 
This reverts commit 5d1e670.
@sanzmauro
pr feedback
336a708
@sanzmauro
pr feedback
5e57a56
@sanzmauro
pr feedbakc
a9ca51e
@sanzmauro
Merge pull request #181 from splitio/factory-cleanup
f192608 
SplitFactory code cleanup
@sanzmauro
Factory code cleanup
6efce1b
@sanzmauro
added tests - wip
26d01fc
@sanzmauro
added integration tests
bd5195d
@sanzmauro
Merge pull request #182 from splitio/localhost-code-cleanup
8a4b97e 
LocalhostClient code cleanup. Move validations.
@sanzmauro
Merge pull request #183 from splitio/evaluator-integration-tests
1b234ae 
Evaluator integration tests
@ldecheverz-split
Adding test to increment Coverage
dbb3100
@NicoZelaya
Merge pull request #185 from splitio/split-factory-tests
10bdfc0 
[Lucas] Adding test to increment Coverage
@ldecheverz-split
LocalhostSplitClient updated
6644f74 
LocalhostSplitManager bug fixed
Typo on SSEClient Fixed
@ldecheverz-split
Using SplitClientImpl instead LocalhostSplitClient in LocalhostFactory
de128d1
@ldecheverz-split
Forgot to change this previous change. SplitCache in SplitClientImpl …
9201e2a 
…remains private.
@ldecheverz-split
Fixing typo
efdc30d
@ldecheverz-split
Merge pull request #188 from splitio/localhost-client-refactor
faf570e 
LocalhostSplitClient Refactor
@sonarqube-pull-requests
Copy link

sonarqube-pull-requests bot commented Mar 5, 2021

SonarQube Quality Gate failed.

Bug C 9 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 92 Code Smells

42.3% 42.3% Coverage
3.4% 3.4% Duplication

sanzmauro
sanzmauro approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@sanzmauro sanzmauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ldecheverz-split
Copy link
Contributor Author

ldecheverz-split commented Mar 9, 2021

Merging Evaluator refactor to development

@ldecheverz-split ldecheverz-split merged commit 563216a into development Mar 9, 2021
@mmelograno mmelograno deleted the evaluator-refactor branch February 22, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanzmauro sanzmauro sanzmauro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ldecheverz-split @sanzmauro @NicoZelaya