This repository was archived by the owner on Dec 20, 2025. It is now read-only.
Repository navigation
fix(serviceAccounts): Delete managed service account when pipeline is deleted (bp #769) - #803
Merged
Conversation
… deleted (#769) Sometime ago, we noticed the sync operation of Fiat was very slow (it was taking between 2 and 3 minutes) and in some cases, the Fiat instance went out of memory. After investigations, we found out that we had about 2000 managed service accounts not associated to any pipelines, deleting them solved our issue with Fiat. This change deletes the managed service account liked to the pipeline currently being deleted. Co-Authored-By: Greg Jones <greg.jones@gmail.com> Co-Authored-By: Mark Vulfson <markvu@live.com> Co-authored-by: Adrien Gentil <adrien.gentil@adevinta.com> Co-authored-by: Greg Jones <greg.jones@gmail.com> Co-authored-by: Mark Vulfson <markvu@live.com> (cherry picked from commit c721dfa)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated backport of pull request #769 done by Mergify
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/