This repository was archived by the owner on Dec 20, 2025. It is now read-only.
Repository navigation
fix(core): In baseProvider, fixed autoselection of React stage - #6673
Merged
Merged
Conversation
alanmquach
requested review from
a user,
anotherchrisberry and
christopherthielen
March 12, 2019 17:25
anotherchrisberry
approved these changes
Mar 12, 2019
Contributor
Author
|
@sbwsg Anytime. Does this need to be cherry-picked to the other releases? |
|
Ah yes good call. |
|
@spinnakerbot cherry-pick 1.12 |
Contributor
|
Cherry pick failed: Command failed (cherry pick commit 7a49d82) with exit code 1: |
alanmquach
added a commit
to alanmquach/deck
that referenced
this pull request
Mar 12, 2019
7a49d82 fix(core): In baseProvider, fixed autoselection of React stage (spinnaker#6673)
alanmquach
added a commit
that referenced
this pull request
Mar 12, 2019
ezimanyi
pushed a commit
that referenced
this pull request
Mar 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't feel great to me but it fixes things.
The problem was that when
We get an
Invariant Violation: Target container is not a DOM element.because we try to immediately auto-select the only cloud provider, but the.react-stage-detailsdiv has not been mounted yet.This defers the React render until after the digest cycle completes. Not great, but I think this can probably hold us over until we port the
baseProvidercode over to React (soon).