This repository was archived by the owner on Dec 20, 2025. It is now read-only.
Repository navigation
feat(core): display unescaped JSON if pipeline parameter input was JSON - #6556
Merged
Merged
Conversation
anotherchrisberry
added a commit
that referenced
this pull request
Feb 18, 2019
* chore(core): Bump version to 0.0.332 b18a815 fix(aws): fix security group rule updates (#6564) 1b42413 fix(core): use $timeout to handle change event in accountSelectField (#6563) 8199164 fix(core/css): be explicit on which file we're importing (#6554) c4287c6 feat(core): display unescaped JSON if pipeline parameter input was JSON (#6556) 6fd4bf3 fix(core): make one request per pipeline/strategy re-indexing event (#6519) 592073f fix(eslint): Fix eslint warnings for @typescript-eslint/camelcase c17c742 fix(eslint): Fix eslint warnings for @typescript-eslint/no-empty d72bc17 fix(eslint): Fix eslint warnings for @typescript-eslint/camelcase 9818dec fix(eslint): Fix eslint warnings for @typescript-eslint/array-type 93d83d6 fix(eslint): Fix eslint warnings for @typescript-eslint/no-namespace e1b6663 fix(eslint): Fix eslint warnings for @typescript-eslint/no-use-before-define aa4e8df fix(eslint): Fix eslint warnings for @typescript-eslint/ban-types cccca97 fix(eslint): Fix eslint warnings for no-extra-boolean-cast 3b8fcd9 fix(eslint): Fix eslint warnings for no-console ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape 8cba7ac fix(eslint): Fix eslint warnings for no-case-declarations * chore(amazon): Bump version to 0.0.172 b18a815 fix(aws): fix security group rule updates (#6564) 7692c2e fix(eslint): Fix eslint warnings for noundef
Contributor
|
What value did you use to test this? It's blowing up on any non-primitive that is parseable as JSON, e.g. an array or JSON object: [1, 2, 3] // fails
{"app": "foo"} // also failsWe would like to fix this but don't want to break whatever you're trying to handle here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a user requested that we display the
ExecutionStatusparameter value as an unescaped JSON if the input was an unescaped JSON. Having an escaped JSON is causing issues with another tool from the user that parses parameters from theExecutionStatusspinnaker/spinnaker#3976