This repository was archived by the owner on Dec 20, 2025. It is now read-only.
Repository navigation
fix(appengine/google/kubernetes): change logo background colors to of… - #6347
Merged
ttomsu merged 1 commit intoJan 10, 2019
Merged
Conversation
…ficial brand colors
ghost
approved these changes
Jan 10, 2019
ttomsu
approved these changes
Jan 10, 2019
anotherchrisberry
added a commit
that referenced
this pull request
Feb 13, 2019
* chore(kubernetes): Bump version to 0.0.21 27d8a12 chore(eslint): Fix lint errors a8c1749 chore(package): Just Update Prettier™ 9eccc0f refactor(artifacts): Generalize artifact delegate for reuse (#6495) 6c54b61 fix(kubernetes): do not override `location` and `replicas` in new Scale Manifest stage a35088a chore(webpack): Switch to TerserPlugin. Split bundles into ~5mb chunks 54157f2 fix(kubernetes/serverGroup): Remove module.exports assignment in typescript file 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages d53836b refactor(kubernetes/modal): Refactor kubernetes modals to use WizardPage component dba26d8 feat(kubernetes/v2): Converts CopyToClipboard to React Component (#6451) 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 65c2601 fix(kubernetes): post strategic patch body as object 51a8542 fix(kubernetes): fix account selection by handling null values passed to ManifestSelector.isExpression 35be1f0 refactor(*): Don't use js or ts file extension in require() a02a5e1 chore(k8s): clean up imports (#6430) fa18bdc feat(kubernetes/v2): Adds CopyToClipboard component to ease getting text from UI (#6419) 98a85e9 chore(*): bump @types/enzyme@3.1.15, @types/jasmine@3.3.7, enzyme@3.8.0, enzyme-adapter-react-16@1.7.1, karma@4.0.0, karma-jasmine@2.0.1, karma-webpack@3.0.5, typescript@^3.2.4, jasmine-core@3.3.0 - disable jasmine 3.0's random test order by default feature 93f1209 fix(appengine/google/kubernetes): change logo background colors to official brand colors (#6347) e802c45 fix(*): allow modal to stay open on auto-close (#6329) 6fee54d fix(kubernetes): specify monospace fonts to prevent cursor misalignment in ace editor 86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280) * chore(google): Bump version to 0.0.5 a8c1749 chore(package): Just Update Prettier™ a35088a chore(webpack): Switch to TerserPlugin. Split bundles into ~5mb chunks 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages d09a910 feat(google): Add support for accelerators when deploying VMs (#6467) 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 35be1f0 refactor(*): Don't use js or ts file extension in require() 87013c6 config(google): Update GCE's base URL to the new domain (#6401) 9f90ebd fix(google): safe healthcheck lookups when cloning server group b920442 fix(google): differentiate among autohealing health check kinds 786862b fix(google): fix autohealing clone logic 93f1209 fix(appengine/google/kubernetes): change logo background colors to official brand colors (#6347) e802c45 fix(*): allow modal to stay open on auto-close (#6329) d4127fa fix(google): prevent parent server group from overwriting null clone autohealing policies 86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280) 3afbd00 fix(bake): Allow null extended attributes in bake stages (#6256) 6b8188b chore(*): Add core alias to module tsconfigs
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jun 5, 2019
e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665) 49affe7 fix(appengine): allow sequence to be suppressed in servergroup names (spinnaker#6667) 7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points e1b6663 fix(eslint): Fix eslint warnings for @typescript-eslint/no-use-before-define ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape a35088a chore(webpack): Switch to TerserPlugin. Split bundles into ~5mb chunks 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 93f1209 fix(appengine/google/kubernetes): change logo background colors to official brand colors (spinnaker#6347) 86baac9 refactor(*): use mask-image CSS for cloud provider logos (spinnaker#6280) 8cef885 fix(appengine): move artifact account dropdown below radio buttons (spinnaker#6255) 6b8188b chore(*): Add core alias to module tsconfigs c190c41 fix(appengine): the selectedProvider is received as null when Create Server Group btn clicked (spinnaker#5908) 351d4fb feat(appengine): unflag container image url deployments (spinnaker#5894) 0a6d3f9 feat(provider/appengine): enable artifacts as config files (spinnaker#5888) bdca8aa feat(appengine): move config template into html file (spinnaker#5870)
christopherthielen
added a commit
that referenced
this pull request
Jun 5, 2019
e2b4d8e refactor(*): remove unused local storage caches (#6665) 49affe7 fix(appengine): allow sequence to be suppressed in servergroup names (#6667) 7d5fc34 chore(prettier): Just Use Prettier™ (#6600) 5cf6c79 chore(prettier): Just Use Prettier™ 3ffa4fb chore(angularjs): Do not use .component('foo', new Foo()) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points e1b6663 fix(eslint): Fix eslint warnings for @typescript-eslint/no-use-before-define ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape a35088a chore(webpack): Switch to TerserPlugin. Split bundles into ~5mb chunks 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 93f1209 fix(appengine/google/kubernetes): change logo background colors to official brand colors (#6347) 86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280) 8cef885 fix(appengine): move artifact account dropdown below radio buttons (#6255) 6b8188b chore(*): Add core alias to module tsconfigs c190c41 fix(appengine): the selectedProvider is received as null when Create Server Group btn clicked (#5908) 351d4fb feat(appengine): unflag container image url deployments (#5894) 0a6d3f9 feat(provider/appengine): enable artifacts as config files (#5888) bdca8aa feat(appengine): move config template into html file (#5870)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ficial brand colors
Currently, we set the background color of all Cloud Provider logos to Spinnaker's
color-successgreen color here.This overrides the GAE, GCE, and Kubernetes logo background colors to match fill colors from official Google SVG files. Probably not worth making color variables for these since they are not part of the Spinnaker color palette.