Skip to content

Conversation

@fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #4123

Description

This PR fixes the windows build by making the playground download compatible with windows and by ensuring windows doesn't try to use wasmtime.

@fredcarle fredcarle added this to the DefraDB v0.20 milestone Nov 1, 2025
@fredcarle fredcarle requested a review from a team November 1, 2025 02:09
@fredcarle fredcarle self-assigned this Nov 1, 2025
@fredcarle fredcarle added the ci/build This is issue is about the build or CI system, and the administration of it. label Nov 1, 2025
@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.23%. Comparing base (ec39063) to head (1a256f0).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4124   +/-   ##
========================================
  Coverage    77.23%   77.23%           
========================================
  Files          482      482           
  Lines        37261    37261           
========================================
+ Hits         28775    28776    +1     
+ Misses        6209     6207    -2     
- Partials      2277     2278    +1     
Flag Coverage Δ
all-tests 77.23% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/db/lens_wasmtime.go 100.00% <ø> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec39063...1a256f0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsimnz
Copy link
Member

jsimnz commented Nov 1, 2025

Discussed with Fred, technically this puts a requirement to build with powershell only on Windows, but it's OK, since it's just the playground and can be fixed later Nevermind, works in both cmd and powershell

@fredcarle fredcarle merged commit 2116835 into sourcenetwork:develop Nov 1, 2025
86 of 89 checks passed
@fredcarle fredcarle deleted the fredcarle/fix/windows-release branch November 1, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build This is issue is about the build or CI system, and the administration of it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows release is broken

2 participants