-
Notifications
You must be signed in to change notification settings - Fork 72
feat: Gate p2p ops with NAC #4111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Gate p2p ops with NAC #4111
Conversation
f3e89a7 to
a28120e
Compare
ChrisBQu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Maybe it makes sense to create/link a second issue that mentions separating out the parts of p2p.go, before merging, since I don't think this PR's title or linked issue implies that at all. Maybe it would be enough to just mention it in the description of this PR before merging. But the code itself looks good.
I already added to the description a few minutes ago, haha. cheers. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4111 +/- ##
===========================================
+ Coverage 77.18% 77.25% +0.07%
===========================================
Files 482 482
Lines 37243 37263 +20
===========================================
+ Hits 28745 28787 +42
+ Misses 6213 6202 -11
+ Partials 2285 2274 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
2e24d9b to
92a500c
Compare
92a500c to
ae62655
Compare
Relevant issue(s)
Resolves #4110
Description
Gate the following P2P ops:
For Reviewers:
Future Todo(s) (ones with tick boxes will likely be done in this PR):
adminrelationadminrelationadminrelationadminrelationGetAllReplicators: Test ListReplicators/GetAllReplicators Operation with NAC #4109