Skip to content

Conversation

@shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented Oct 23, 2025

Relevant issue(s)

Resolves #4099

Description

  • Gate Document Read Operation.
  • Gate Document Delete Operation.
  • Gate Document Update Operation.

Note: Gating document creation with document-update perm

@shahzadlone shahzadlone added this to the DefraDB v0.20 milestone Oct 23, 2025
@shahzadlone shahzadlone requested a review from a team October 23, 2025 12:53
@shahzadlone shahzadlone self-assigned this Oct 23, 2025
@shahzadlone shahzadlone added feature New feature or request area/acp Related to the acp (access control) system needed for v1 labels Oct 23, 2025
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.30%. Comparing base (5ceff07) to head (0dbdd92).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
internal/db/collection.go 42.86% 5 Missing and 3 partials ⚠️
internal/db/collection_delete.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4100      +/-   ##
===========================================
+ Coverage    77.20%   77.30%   +0.10%     
===========================================
  Files          478      478              
  Lines        36933    36953      +20     
===========================================
+ Hits         28513    28565      +52     
+ Misses        6169     6150      -19     
+ Partials      2251     2238      -13     
Flag Coverage Δ
all-tests 77.30% <50.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
acp/types/types.go 100.00% <ø> (ø)
internal/db/collection_get.go 61.54% <100.00%> (+1.22%) ⬆️
internal/db/collection_update.go 79.44% <100.00%> (+0.39%) ⬆️
internal/db/collection_delete.go 46.36% <0.00%> (-0.86%) ⬇️
internal/db/collection.go 71.11% <42.86%> (-0.75%) ⬇️

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ceff07...0dbdd92. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shahzadlone shahzadlone changed the title feat: Gate document ops with NAC feat: Gate collection doc ops with NAC Oct 23, 2025
Copy link
Collaborator

@ChrisBQu ChrisBQu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzadlone shahzadlone force-pushed the lone/feat/gate-document-ops branch from b835aee to ff9e39b Compare October 23, 2025 18:26
@shahzadlone shahzadlone force-pushed the lone/feat/gate-document-ops branch from ff9e39b to 0dbdd92 Compare October 23, 2025 20:10
@shahzadlone shahzadlone merged commit f81bf8e into sourcenetwork:develop Oct 23, 2025
111 of 125 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/acp Related to the acp (access control) system feature New feature or request needed for v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gate document crud ops with NAC

2 participants