fix: Default json value #4064
Merged
fix: Default json value #4064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4064 +/- ##
===========================================
+ Coverage 73.97% 74.04% +0.07%
===========================================
Files 477 477
Lines 43754 43766 +12
===========================================
+ Hits 32367 32406 +39
+ Misses 9176 9158 -18
+ Partials 2211 2202 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
fredcarle
reviewed
Oct 10, 2025
| // Since setting a default value to nil is the same as not providing one, | ||
| // it is safer to return an error to let the user know something is wrong. | ||
| if value == nil { | ||
| // Exception: JSON fields can have nil as a valid default value |
Collaborator
There was a problem hiding this comment.
question: Why do we treat the JSON type differently?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #3146
Description
Fix default json value by properly converting it's value into a corresponding type.