-
Notifications
You must be signed in to change notification settings - Fork 72
fix: Enable doc encryption for embedded client #3755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Enable doc encryption for embedded client #3755
Conversation
a7ffcda to
50f941f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3755 +/- ##
===========================================
+ Coverage 77.18% 77.24% +0.05%
===========================================
Files 422 423 +1
Lines 38257 38289 +32
===========================================
+ Hits 29528 29573 +45
+ Misses 6855 6847 -8
+ Partials 1874 1869 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
jsimnz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor suggestion raised on some of the param types.
One thing I wanted to highlight as a general convo (non blocker to this PR) - Long term, how much do we want to expose the manual API for (field-level) doc encryption vs soley relying on the policy/schema to determine and inform the rest of the system when docs and fields should be encrypted. (We can have this discussion in discord if prefered)
Encrypt a document or not is a decision made for each individual document, the same applies to fields. Policy is something that is globally applied to all documents. Are you suggesting abandoning the idea of having field-level encryption individually configurable? |
nasdf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Don't forget to update the JS client as well. It is using the context method like the CLI was.
This does sound like an easily avoidable user-complication, but I've not thought a whole load about it and I cant remember a previous discussion around it. |
AndrewSisley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
3ace050 to
924b38a
Compare
## Relevant issue(s) Resolves [sourcenetwork#3754](sourcenetwork#3754) ## Description Add create doc options to collection create-doc-related methods. The options allow specifying parameters for doc encryption. As opposed to the previous approach with passing the context, this moves parameters handing into the interface and unifies it for all clients.
Relevant issue(s)
Resolves #3754
Description
Add create doc options to collection create-doc-related methods.
The options allow specifying parameters for doc encryption.
As opposed to the previous approach with passing the context, this moves parameters handing into the interface and unifies it for all clients.