Skip to content

Conversation

@getify
Copy link
Contributor

@getify getify commented Apr 29, 2025

per @jsimnz

@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.04%. Comparing base (e540bb6) to head (7acdabf).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3647      +/-   ##
===========================================
- Coverage    78.07%   78.04%   -0.02%     
===========================================
  Files          408      408              
  Lines        37344    37344              
===========================================
- Hits         29154    29145       -9     
- Misses        6405     6411       +6     
- Partials      1785     1788       +3     
Flag Coverage Δ
all-tests 78.04% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e540bb6...7acdabf. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsimnz jsimnz changed the title README: removing outdate disclaimer about lack of encryption docs: Remove outdated disclaimer about lack of encryption Apr 29, 2025
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: I think for the disclaimer, we can leave the rest about production ready status. For the "do not use it for production purposes", we can lighten up this language a bit since we do currently have some partners using in prod.

Instead we can say something like: "we encourage teams looking to deploy to production to reach out to us". Or something to that affect.

@getify getify changed the title docs: Remove outdated disclaimer about lack of encryption docs: Update outdated disclaimer about lack of encryption Apr 30, 2025
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps docs(i): .. in title.

LGTM

@getify getify force-pushed the getify-patch-1 branch from c23341c to 25cd780 Compare May 1, 2025 12:36
@jsimnz
Copy link
Member

jsimnz commented May 2, 2025

Perhaps docs(i): .. in title.

I don't think the i is necessary. Its fine to have this in the changelog

@getify getify force-pushed the getify-patch-1 branch from 25cd780 to 7acdabf Compare May 3, 2025 05:15
@getify getify merged commit 9627368 into develop May 4, 2025
45 of 47 checks passed
@getify getify deleted the getify-patch-1 branch May 4, 2025 03:46
ChrisBQu pushed a commit to ChrisBQu/defradb that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants