refactor: Make validator return joined errors #3513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3513 +/- ##
===========================================
+ Coverage 78.46% 78.56% +0.10%
===========================================
Files 391 391
Lines 36424 36466 +42
===========================================
+ Hits 28577 28647 +70
+ Misses 6144 6123 -21
+ Partials 1703 1696 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 17 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
AndrewSisley
approved these changes
Mar 17, 2025
Contributor
AndrewSisley
left a comment
There was a problem hiding this comment.
LGTM, and is a nice improvement - thanks Chris :)
ChrisBQu
added a commit
to ChrisBQu/defradb
that referenced
this pull request
Apr 25, 2025
## Relevant issue(s) Resolves sourcenetwork#2568 ## Description Validator functions currently were returning singular errors when encountered. With this change, they will instead return a list of errors that are encountered, by using the Join() function on the errors. To accommodate this change, additional logic was added to some validator functions to check for nil values being passed in. This is to avoid and prevent nil pointer exceptions. This is still in progress. ## Tasks - [x] I made sure the code is well commented, particularly hard-to-understand areas. - [x] I made sure the repository-held documentation is changed accordingly. - [x] I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in [tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)). - [x] I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ... ## How has this been tested? Specify the platform(s) on which this was tested: - Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2568
Description
Validator functions currently were returning singular errors when encountered. With this change, they will instead return a list of errors that are encountered, by using the Join() function on the errors.
To accommodate this change, additional logic was added to some validator functions to check for nil values being passed in. This is to avoid and prevent nil pointer exceptions.
This is still in progress.
Tasks
How has this been tested?
Specify the platform(s) on which this was tested: